Community
Participate
Working Groups
According to https://twitter.com/gaparv/status/1287476922897895424 the default for Windows and Linux is now to use flat tabs, while macOS uses rounded tabs still. Implement the necessary fixes to ensure consistency between operating systems.
Created attachment 283715 [details] Screenshot showing flat tabs
@Alex I saw the discussion on twitter. From what I gather, the issue is that the inactive tabs are using a color gradient. Although I can't do testing myself as I don't own a Mac, I can help with the CSS fix/review.
I see the rounded tabs on 2020-03 with the Eclipse IDE for Eclipse Committer package, but not with the 2020-06 Eclipse IDE for Eclipse Committers package.
(In reply to Alex Blewitt from comment #3) > I see the rounded tabs on 2020-03 with the Eclipse IDE for Eclipse Committer > package, but not with the 2020-06 Eclipse IDE for Eclipse Committers package. See my previous comment, I believe Gayan's issue is the colors are not flat (a gradient is used) despite the fact that square corners are now being used on OSX.
(In reply to Andrew Obuchowicz from comment #4) > (In reply to Alex Blewitt from comment #3) > > I see the rounded tabs on 2020-03 with the Eclipse IDE for Eclipse Committer > > package, but not with the 2020-06 Eclipse IDE for Eclipse Committers package. > > See my previous comment, I believe Gayan's issue is the colors are not flat > (a gradient is used) despite the fact that square corners are now being used > on OSX. Ah, I see. Will verify that is indeed the case. If you know where/how I can apply the CSS fixes, I'm more than happy to build/test it. Or if you want to propose a Gerrit, I can pull that and do the verification - whichever is easier :)
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166907
> Ah, I see. Will verify that is indeed the case. If you know where/how I can > apply the CSS fixes, I'm more than happy to build/test it. Or if you want to > propose a Gerrit, I can pull that and do the verification - whichever is > easier :) Awesome thank you! I tried making a Gerrit, hopefully it fixes the issue :P Will add you as a reviewer :)
Created attachment 283716 [details] Screenshot with fix for patch 1 of gerrit change
So in the fix for patchset 1 at https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166907 it looks pretty good, but I will see if I can tweak it to be a little bit more native.
Created attachment 283720 [details] Sreenshot showing D6D6D6 colouring
Created attachment 283721 [details] Screenshot showing F6F6F6
