Community
Participate
Working Groups
Created attachment 283383 [details] COnsole buttons in History view Build id: I20200622-1800. I've opened History view, it was focused on Platform UI repo (if that is important), and after that started runtime Eclipse for debugging. Buttons from the Console view activated in background in the same stack were added to the toolbar of the History view!!! Console buttons were fully enabled / drop-down to create new Consoles was selectable, I could terminate the new launch from History view etc. After clicking on Console view to show it, buttons disappeared from History view. Must be some recent regression, unfortunately I have no idea how to reproduce it (tried same steps, no luck).
Possibly related? - bug 564299 - bug 562645 - bug 563547
I wouldn't be surprised if this is another incarnation of Bug 564290. The parts are created lazily in the StackRenderer. It seems that the console part is created (lazily) when an Eclipse instance is created, however it does not become visible yet. The same code that triggers that the toolbar will be hidden (Bug 564290), can cause that the toolbar will be visible always (also related to Bug 563086). That is, the toolbar is flagged visible, even if the part is still not in top of the tabfolder. If it is indeed Bug 564290, it the triggering of this situation depends on the order in which some listeners are triggered. And the probability that is triggered seems to be going down.
I cannot reproduce.
*** Bug 564994 has been marked as a duplicate of this bug. ***
As seen in bug 564994, it is not Linux only issue and not only for Console, I've updated the title. That is definitely regression in 4.17 & *must* be fixed.
The attachment 283526 [details] from bug 564994 shows that Variables view (in front) contains additionally buttons from *two* hidden views that are in the same stack - Breakpoints and Expressions.
Yes, this is a severe regression. We need to solve this as it confuses user.
(In reply to Sarika Sinha from comment #7) > Yes, this is a severe regression. We need to solve this as it confuses user. Is this reproducable for you? So far I was not able to produce Andreys example.
(In reply to Lars Vogel from comment #8) > (In reply to Sarika Sinha from comment #7) > > Yes, this is a severe regression. We need to solve this as it confuses user. > > Is this reproducable for you? So far I was not able to produce Andreys > example. Not the console view issue, But I am consistently able to reproduce Variables/Breakpoint/Expression View issue.
(In reply to Sarika Sinha from comment #9) > Not the console view issue, But I am consistently able to reproduce > Variables/Breakpoint/Expression View issue. Can you please provide steps to reproduce?
(In reply to Andrey Loskutov from comment #10) > (In reply to Sarika Sinha from comment #9) > > Not the console view issue, But I am consistently able to reproduce > > Variables/Breakpoint/Expression View issue. > > Can you please provide steps to reproduce? 1. Launch Eclipse I20200706-2300 with Java 13 2. A simple program like package t13; public class a1 { public static void main(String[] args) { var a = "hello"; System.out.println(a); } } 3. Debug with Breakpoint at sysout 4. Choose to switch perspective when it asks. 5. The Variable view shows duplicate icons from Breakpoint or Expression view.
Couldn't this be regression from bug 562892? Sounds like a perfect match: "Bug 562892 - Calling toBeRendered on a view toolbar breaks UI" https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/162592/
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165977
(In reply to Andrey Loskutov from comment #12) > Couldn't this be regression from bug 562892? Sounds like a perfect match: > > "Bug 562892 - Calling toBeRendered on a view toolbar breaks UI" > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/162592/ Indeed it is related to this one. Not sure how it worked before but do know what was the cause now: The MParts are lazily created, any toolbar on a non-visible part is marked invisible. Most of the time the views are only rendered when they become visible. However, the not visible MParts in the debug view are rendered in the 'background' when the debugger runs. That is, the MParts are already rendered even if they are not on top. The rendering of parts trigggers that a toolbar is added in the CompatibiltyView. This new toolbar is not marked invisible. The submitted change listens for toolbars that are added to the model, it marks the toolbars (in)visible depending if the Part is visible or not.
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165977 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0bfddfbc18467d59452d1cb28ef180e2f6fd4c07
(In reply to Eclipse Genie from comment #15) > Gerrit change > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165977 was merged > to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=0bfddfbc18467d59452d1cb28ef180e2f6fd4c07 From the review, this change fixes the issue for new workspaces (or after -clearPersistedState). The issue remains for workspaces that were created with older versions.
(In reply to Rolf Theunissen from comment #16) > (In reply to Eclipse Genie from comment #15) > > Gerrit change > > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165977 was merged > > to [master]. > > Commit: > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > > ?id=0bfddfbc18467d59452d1cb28ef180e2f6fd4c07 > > From the review, this change fixes the issue for new workspaces (or after > -clearPersistedState). The issue remains for workspaces that were created > with older versions. Verified with Build id: I20200716-1800
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166560
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166560 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=06c08046e77b6ca385a518ae4fd8168756012c53
*** Bug 565725 has been marked as a duplicate of this bug. ***
