564144 – Remove dead code from org.eclipse.ui.internal

Bug 564144 - Remove dead code from org.eclipse.ui.internal

Summary: Remove dead code from org.eclipse.ui.internal

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.16
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.17 M3
Assignee:	Rolf Theunissen
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:	563974
Blocks:	566050
	Show dependency tree

Reported:	2020-06-09 16:03 EDT by Rolf Theunissen
Modified:	2020-08-13 15:10 EDT (History)
CC List:	1 user (show)

See Also:	Gerrit Change Gerrit Change Git Commit Git Commit Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change 563485 Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Gerrit Change Git Commit Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Gerrit Change 564975 Gerrit Change Git Commit Git Commit

Attachments
Partial output from UCDetector (95.66 KB, text/plain) 2020-06-09 16:03 EDT, Rolf Theunissen	no flags	Details
Partial output from UCDetector (103.88 KB, text/plain) 2020-06-23 14:53 EDT, Rolf Theunissen	no flags	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rolf Theunissen

2020-06-09 16:03:47 EDT

Created attachment 283207 [details]
Partial output from UCDetector

While working on Bug 563974, I took the liberty of running UCDetector [1] on the platform UI codebase.

For the org.eclipse.ui.internal package of org.eclipse.ui.workbench alone, it finds around 40 classes that potentially not used. Furthermore, there are a lot of  constants, fields and methods that are not referenced (around 500 total).
I expect that there are (some) false positives in the results. But there is surely dead code that can be removed.

Note for anybody that wants to run the tool too: The tool will find false positives for injected fields/methods. To reduce the number of false positive, you can add additional annotations that should be ignored (e.g. PostConstruct, PreDestroy, Persist, CanExecute, Execute, SetEnabled)

[1] http://www.ucdetector.org/

Comment 1 Lars Vogel

2020-06-09 16:27:03 EDT

Great work. +1 for removal.

Just one additional check would be to check plugin.xml for usage of such classes. IIRC Brian once suggest to write a test for such cases not sure if we finished that....

Comment 2 Eclipse Genie

2020-06-11 16:35:00 EDT

New Gerrit change created: https://git.eclipse.org/r/164740

Comment 3 Eclipse Genie

2020-06-11 16:35:19 EDT

New Gerrit change created: https://git.eclipse.org/r/164741

Comment 4 Lars Vogel

2020-06-11 16:36:31 EDT Comment hidden (obsolete)

Rolf and all others, can you check a few from Rolfs list and delete the selected once? Would be nice if that can be a group effort.

I picked two of the classes, deleted them and ran a full text search for the repo (and included multiple others) to ensure they are not used somewhere.

Comment 5 Lars Vogel

2020-06-11 16:36:39 EDT

Rolf and all others, can you check a few from Rolfs list and delete the selected once? Would be nice if that can be a group effort.

I picked two of the classes, deleted them and ran a full text search for the repo (and included multiple others) to ensure they are not used somewhere.

Comment 6 Eclipse Genie

2020-06-12 03:13:20 EDT

Gerrit change https://git.eclipse.org/r/164740 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0bb2f42aa79fc8962da0cca84f9ecd34d3be82c6

Comment 7 Eclipse Genie

2020-06-12 03:13:25 EDT

Gerrit change https://git.eclipse.org/r/164741 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=88655f1e7609ce2f5a58c4d3e9b00facd85f9dea

Comment 8 Eclipse Genie

2020-06-13 09:28:23 EDT

New Gerrit change created: https://git.eclipse.org/r/164825

Comment 9 Eclipse Genie

2020-06-13 09:30:38 EDT

New Gerrit change created: https://git.eclipse.org/r/164826

Comment 10 Eclipse Genie

2020-06-13 09:44:19 EDT

New Gerrit change created: https://git.eclipse.org/r/164828

Comment 11 Eclipse Genie

2020-06-13 10:31:38 EDT

New Gerrit change created: https://git.eclipse.org/r/164829

Comment 12 Lars Vogel

2020-06-14 09:36:29 EDT

FYI - I work from the classes bottom up, looks like you start from the top, so hopefully we do not do double work.

Comment 13 Eclipse Genie

2020-06-14 09:36:57 EDT

New Gerrit change created: https://git.eclipse.org/r/164847

Comment 14 Eclipse Genie

2020-06-14 09:38:07 EDT

New Gerrit change created: https://git.eclipse.org/r/164848

Comment 15 Eclipse Genie

2020-06-14 09:39:27 EDT

New Gerrit change created: https://git.eclipse.org/r/164849

Comment 16 Eclipse Genie

2020-06-14 13:19:48 EDT

Gerrit change https://git.eclipse.org/r/164825 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=19f4745a5ddc57922818553eb544f65f492b74cb

Comment 17 Eclipse Genie

2020-06-14 13:20:33 EDT

Gerrit change https://git.eclipse.org/r/164826 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2d0a20d1e50d7322f3cc7ed11face32e43a4304e

Comment 18 Eclipse Genie

2020-06-14 13:21:48 EDT

Gerrit change https://git.eclipse.org/r/164828 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d8ab1068048b58172c3e78ab6f6865e3b9db5837

Comment 19 Eclipse Genie

2020-06-14 13:22:12 EDT

Gerrit change https://git.eclipse.org/r/164827 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=08bd8f642e6d98fd53b5cc2e43282529aba6f228

Comment 20 Eclipse Genie

2020-06-14 13:22:16 EDT

Gerrit change https://git.eclipse.org/r/164829 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d76f4a81554b588252db7e55c6cfd992eac1add4

Comment 21 Eclipse Genie

2020-06-15 02:18:50 EDT

Gerrit change https://git.eclipse.org/r/164847 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=97ea36f53734c6c4865fd524c60442e80023ca3a

Comment 22 Eclipse Genie

2020-06-15 02:19:35 EDT

Gerrit change https://git.eclipse.org/r/164849 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c741a2be1cd618388d64e318f37fedab04321878

Comment 23 Eclipse Genie

2020-06-15 03:58:42 EDT

Gerrit change https://git.eclipse.org/r/164848 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=21f53331f85afe60c4679965d5617a1c720f2081

Comment 24 Eclipse Genie

2020-06-15 04:01:57 EDT

New Gerrit change created: https://git.eclipse.org/r/164878

Comment 25 Eclipse Genie

2020-06-15 08:52:21 EDT

Gerrit change https://git.eclipse.org/r/164878 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e9eb501f0c02985fb32e81150fd8a26b11c8b40e

Comment 26 Eclipse Genie

2020-06-16 15:43:22 EDT

New Gerrit change created: https://git.eclipse.org/r/165017

Comment 27 Eclipse Genie

2020-06-17 01:56:47 EDT

Gerrit change https://git.eclipse.org/r/165017 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ea386eb32875dc5c12e8109685a7e0b61dba927f

Comment 28 Eclipse Genie

2020-06-18 08:00:18 EDT

New Gerrit change created: https://git.eclipse.org/r/165143

Comment 29 Eclipse Genie

2020-06-18 10:05:37 EDT

Gerrit change https://git.eclipse.org/r/165143 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=427efc516331c0ddb2f824c8d7d81749710840e9

Comment 30 Eclipse Genie

2020-06-18 10:07:51 EDT

New Gerrit change created: https://git.eclipse.org/r/165162

Comment 31 Eclipse Genie

2020-06-18 10:07:56 EDT

New Gerrit change created: https://git.eclipse.org/r/165163

Comment 32 Eclipse Genie

2020-06-18 10:08:11 EDT

New Gerrit change created: https://git.eclipse.org/r/165164

Comment 33 Eclipse Genie

2020-06-18 11:28:07 EDT

Gerrit change https://git.eclipse.org/r/165162 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ebc5e789668923e097d13a0443dd525586e24312

Comment 34 Eclipse Genie

2020-06-18 13:03:13 EDT

Gerrit change https://git.eclipse.org/r/165163 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b1da3ecef1e666f45ab4c480eab829b39a72028c

Comment 35 Eclipse Genie

2020-06-19 03:26:29 EDT

Gerrit change https://git.eclipse.org/r/165164 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=caf7e53233f18c116d58275c078c7a611444b2af

Comment 36 Eclipse Genie

2020-06-22 06:13:40 EDT

New Gerrit change created: https://git.eclipse.org/r/165286

Comment 37 Lars Vogel

2020-06-22 06:16:22 EDT

Rolf, could you run UCDectector again and update the attachment to reflect the current state of work?

Comment 38 Eclipse Genie

2020-06-22 09:15:19 EDT

Gerrit change https://git.eclipse.org/r/165286 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1d5ae1fc79c6e08e0856c125cbd730ac7cad377d

Comment 39 Eclipse Genie

2020-06-22 10:35:51 EDT

New Gerrit change created: https://git.eclipse.org/r/165308

Comment 40 Rolf Theunissen

2020-06-23 14:53:15 EDT

Created attachment 283386 [details]
Partial output from UCDetector

Current status, including code only used in test. Note that I only have platform.ui in the workspace.

Comment 41 Eclipse Genie

2020-06-23 14:58:04 EDT

New Gerrit change created: https://git.eclipse.org/r/165374

Comment 42 Eclipse Genie

2020-06-23 15:04:14 EDT

New Gerrit change created: https://git.eclipse.org/r/165376

Comment 43 Eclipse Genie

2020-06-23 15:07:29 EDT

New Gerrit change created: https://git.eclipse.org/r/165377

Comment 44 Eclipse Genie

2020-06-23 15:10:43 EDT

New Gerrit change created: https://git.eclipse.org/r/165378

Comment 45 Eclipse Genie

2020-06-23 15:15:59 EDT

New Gerrit change created: https://git.eclipse.org/r/165379

Comment 46 Eclipse Genie

2020-06-23 15:24:26 EDT

New Gerrit change created: https://git.eclipse.org/r/165381

Comment 47 Eclipse Genie

2020-06-23 15:26:41 EDT

New Gerrit change created: https://git.eclipse.org/r/165382

Comment 48 Eclipse Genie

2020-06-23 15:28:57 EDT

New Gerrit change created: https://git.eclipse.org/r/165383

Comment 49 Eclipse Genie

2020-06-23 16:25:16 EDT

Gerrit change https://git.eclipse.org/r/165381 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=78cf7c1af6230fd71fafcd097af581c6fbbb67db

Comment 50 Eclipse Genie

2020-06-23 16:47:43 EDT

Gerrit change https://git.eclipse.org/r/165382 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3471cc7424c81709240cc953fc23a1256ef62f77

Comment 51 Eclipse Genie

2020-06-24 02:45:36 EDT

Gerrit change https://git.eclipse.org/r/165308 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2decc0db71d81baf1dd0b04d9e9ed5470496d653

Comment 52 Lars Vogel

2020-06-24 05:35:14 EDT

LegacyTrim is used (full text search). Does UCDector allow to define exceptions?

Comment 53 Lars Vogel

2020-06-24 05:37:40 EDT

RGBVisibleContrastColorFactory is also used (JDT)

Comment 54 Eclipse Genie

2020-06-24 05:37:58 EDT

New Gerrit change created: https://git.eclipse.org/r/165398

Comment 55 Eclipse Genie

2020-06-24 05:39:55 EDT

New Gerrit change created: https://git.eclipse.org/r/165400

Comment 56 Eclipse Genie

2020-06-24 05:40:39 EDT

New Gerrit change created: https://git.eclipse.org/r/165401

Comment 57 Eclipse Genie

2020-06-24 05:58:17 EDT

Gerrit change https://git.eclipse.org/r/165234 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1e8a04c7dacf72495e67cd4cf5d555eb2b36dce1

Comment 58 Eclipse Genie

2020-06-24 05:58:21 EDT

Gerrit change https://git.eclipse.org/r/165374 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=815fb0aa6dfb3d7c6ff5e3f876c68d0ab15814da

Comment 59 Eclipse Genie

2020-06-24 05:58:35 EDT

Gerrit change https://git.eclipse.org/r/165378 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=991209fe63bf47966a2febe2464afe67a482617b

Comment 60 Eclipse Genie

2020-06-24 05:58:40 EDT

Gerrit change https://git.eclipse.org/r/165379 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=65d22391d99ca4b8f4fa55beac59d87e1eb9961a

Comment 61 Eclipse Genie

2020-06-24 05:58:54 EDT

Gerrit change https://git.eclipse.org/r/165376 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0392a8bc3452d4d8ccc351b5b07210cfb71f3f46

Comment 62 Eclipse Genie

2020-06-24 05:59:10 EDT

Gerrit change https://git.eclipse.org/r/165383 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c7fd8819ffabed898826d6922c1dceb367f45bc0

Comment 63 Eclipse Genie

2020-06-24 06:01:24 EDT

Gerrit change https://git.eclipse.org/r/165377 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=086089ee52f93636f3c741028e34a73edeefc5d2

Comment 64 Eclipse Genie

2020-06-24 07:42:19 EDT

Gerrit change https://git.eclipse.org/r/165398 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4ad07dffd67f899dec87c63bb98db776e72aa570

Comment 65 Eclipse Genie

2020-06-24 07:42:24 EDT

Gerrit change https://git.eclipse.org/r/165401 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d47df2901197aa43a7e134b29f6ef1b472d0b0ad

Comment 66 Eclipse Genie

2020-06-24 07:42:38 EDT

Gerrit change https://git.eclipse.org/r/165400 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=df45709ca4e16e82f72e55edc67cbd063b91b1e7

Comment 67 Rolf Theunissen

2020-06-24 08:00:59 EDT

(In reply to Lars Vogel from comment #52)
> LegacyTrim is used (full text search). Does UCDector allow to define
> exceptions?

Check the website, they support multiple ways of defining exceptions, e.g. with a special annotation or comment. There is some configuration too.

b.t.w I opened Bug 564397 to get similar functionality in JDT.

Comment 68 Eclipse Genie

2020-07-03 05:52:55 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165791

Comment 69 Lars Vogel

2020-07-03 06:08:18 EDT

As the WorkbenchMessagas, didn't we have a tool which cleans-up unused messages?

Comment 70 Eclipse Genie

2020-07-07 11:29:32 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165971

Comment 71 Eclipse Genie

2020-07-14 04:03:45 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165791 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f1d1f8140897721a24b5f001f7880e74b8056eb6

Comment 72 Eclipse Genie

2020-07-14 07:04:11 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165971 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d1a6bf9ed982e9065ae0d80e33ec4ea609a76a23

Comment 73 Lars Vogel

2020-07-20 06:19:44 EDT

Rolf, can you update the output of UCDector?

Comment 74 Lars Vogel

2020-07-22 04:17:33 EDT

This one got really bit, suggesting to close this one as fixed and potentially continue with a new bug. Rolf, please reopen if you disagree and would like to continue using this one.