Bug 563846 - Enable API check for new bundles introduced in 4.16
Summary: Enable API check for new bundles introduced in 4.16
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.16   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 4.17 M1   Edit
Assignee: Sravan Kumar Lakkimsetti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 563834
  Show dependency tree
 
Reported: 2020-06-02 12:10 EDT by Sravan Kumar Lakkimsetti CLA
Modified: 2020-06-18 05:50 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sravan Kumar Lakkimsetti CLA 2020-06-02 12:10:34 EDT
Enable API check for new bundles introduced in 4.16
Comment 1 Sravan Kumar Lakkimsetti CLA 2020-06-04 07:47:25 EDT
Based on https://download.eclipse.org/eclipse/downloads/drops4/I20200603-0600/buildlogs/reporeports/reports/versionChecks.html

These 4 bundles are newly introduced 
org.eclipse.e4.ui.swt.win32   1.0.600.v20200414-1657  
Eclipse UI WIN32 Enhancements
org.eclipse.e4.ui.swt.win32.source   1.0.600.v20200414-1657  
Eclipse UI WIN32 Enhancements Source
org.eclipse.jface.notifications   0.1.0.v20200511-0837  
Notification API
org.eclipse.jface.notifications.source   0.1.0.v20200511-0837  
Notification API Source
Comment 2 Eclipse Genie CLA 2020-06-04 07:48:04 EDT
New Gerrit change created: https://git.eclipse.org/r/164163
Comment 4 Sravan Kumar Lakkimsetti CLA 2020-06-05 09:59:46 EDT
Merged to master
Comment 5 Eclipse Genie CLA 2020-06-07 09:02:35 EDT
New Gerrit change created: https://git.eclipse.org/r/164380
Comment 6 Lars Vogel CLA 2020-06-07 09:04:48 EDT
This change failed our Gerrit verification hence I reverted it.

See for example https://ci.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/22848/console

14:09:11 [ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-eclipserun-plugin:1.7.0:eclipse-run (api-analysis) on project org.eclipse.e4.ui.swt.win32: Error while executing platform: Error while executing platform (return code: 4) -> [Help 1]
14:09:11 [ERROR] 
14:09:11 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
14:09:11 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
14:09:11 [ERROR] 
14:09:11 [ERROR] For more information about the errors and possible solutions, please read the following articles:
14:09:11 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
14:09:11 [ERROR] 
14:09:11 [ERROR] After correcting the problems, you can resume the build with the command
14:09:11 [ERROR]   mvn <args> -rf :org.eclipse.e4.ui.swt.win32
Comment 7 Lars Vogel CLA 2020-06-07 09:04:57 EDT
.
Comment 8 Alexander Kurtakov CLA 2020-06-07 09:10:47 EDT
IMHO version should be bumped.
Comment 9 Lars Vogel CLA 2020-06-07 09:11:16 EDT
Somehow I pushed it directly, first the push went to the wrong branch, afterwards directly to the Git repo. Sorry for that e34c2c9aec6d5b0a2681b07302e5c03452753416 is the revert.
Comment 10 Eclipse Genie CLA 2020-06-07 09:14:47 EDT
New Gerrit change created: https://git.eclipse.org/r/164381
Comment 11 Eclipse Genie CLA 2020-06-07 09:22:00 EDT
New Gerrit change created: https://git.eclipse.org/r/164382
Comment 13 Sravan Kumar Lakkimsetti CLA 2020-06-17 08:34:40 EDT
(In reply to Eclipse Genie from comment #11)
> New Gerrit change created: https://git.eclipse.org/r/164382

Can we push this one? We are doing comparison with 4.16RC2 earlier and now doing with 4.16 release.
Comment 15 Sravan Kumar Lakkimsetti CLA 2020-06-17 10:43:20 EDT
merged to master
Comment 16 Lars Vogel CLA 2020-06-18 04:41:44 EDT
Gerrit are failing, sounds like this check is causing this:

See https://ci.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/23169/consoleFull

10:12:39 [INFO] --- tycho-eclipserun-plugin:1.7.0:eclipse-run (api-analysis) @ org.eclipse.e4.ui.swt.win32 ---
10:12:39 [INFO] Toolchain in tycho-eclipserun-plugin: JDK[/opt/tools/java/oracle/jdk-8/latest/jre]
10:12:39 [INFO] Expected eclipse log file: /home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/bundles/org.eclipse.e4.ui.swt.win32/target/eclipserun-work/data/.metadata/.log
10:12:39 [INFO] Command line:
10:12:39 	[/opt/tools/java/oracle/jdk-8/latest/jre/bin/java, -Xmx2048M, -jar, /home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/.repository/p2/osgi/bundle/org.eclipse.equinox.launcher/1.5.700.v20200207-2156/org.eclipse.equinox.launcher-1.5.700.v20200207-2156.jar, -install, /home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/bundles/org.eclipse.e4.ui.swt.win32/target/eclipserun-work, -configuration, /home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/bundles/org.eclipse.e4.ui.swt.win32/target/eclipserun-work/configuration, -data, /home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/bundles/org.eclipse.e4.ui.swt.win32/../target/org.eclipse.e4.ui.swt.win32-apiAnalyzer-workspace, -application, org.eclipse.pde.api.tools.apiAnalyzer, -project, /home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/bundles/org.eclipse.e4.ui.swt.win32, -baseline, /home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/bundles/org.eclipse.e4.ui.swt.win32/target/org.eclipse.e4.ui.swt.win32-apiBaseline.target, -dependencyList, /home/jenkins/agent/workspace/eclipse.platform.ui-Gerrit/bundles/org.eclipse.e4.ui.swt.win32/target/dependencies-list.txt, -failOnError]
10:12:43 org.eclipse.core.runtime.CoreException: Problems occurred while resolving the target contents
10:12:43 	at org.eclipse.pde.api.tools.internal.ApiAnalysisApplication.setBaseline(ApiAnalysisApplication.java:258)
10:12:43 	at org.eclipse.pde.api.tools.internal.ApiAnalysisApplication.start(ApiAnalysisApplication.java:120)
10:12:43 	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
10:12:43 	at org.eclipse.equinox.internal.app.AnyThreadAppLauncher.run(AnyThreadAppLauncher.java:30)
10:12:43 	at java.lang.Thread.run(Thread.java:748)
10:12:43 Contains: Cannot complete the install because some dependencies are not satisfiable
Comment 17 Eclipse Genie CLA 2020-06-18 05:07:21 EDT
New Gerrit change created: https://git.eclipse.org/r/165123
Comment 18 Mickael Istria CLA 2020-06-18 05:15:38 EDT
Case of org.eclipse.e4.ui.swt.win32 is an instance of bug 564404.
Let's skip this bundle for the moment to allow CI to work and further progress on other topics; and improving that would then be tracked in bug 564404