Community
Participate
Working Groups
Created attachment 283044 [details] Screenshot Looks like a regression. Show in does not include the Project Explorer anymore in Eclipse SDK Version: 2020-06 (4.16) Build id: I20200525-0929 OS: Linux, v.5.4.0-31-generic, x86_64 / gtk 3.24.18, WebKit 2.28.2 Java version: 1.8.0_252
No recent changes in OpenResourceDialog (last one ~ 2 years ago).
That depends on selected perspective. Open "Git" one and you will see nothing, open "Java" and you will see everything.
(In reply to Andrey Loskutov from comment #2) > That depends on selected perspective. Open "Git" one and you will see > nothing, open "Java" and you will see everything. Thanks Andrey. I was using the debug perspective, IMHO it should also be available here. Adjusted the bug report.
Will CDT user in debug perspective be interested in that? Debug perspective is common for Platform.
(In reply to Sarika Sinha from comment #4) > Will CDT user in debug perspective be interested in that? > > Debug perspective is common for Platform. Jonah, can you answer that? AFAIK CDT uses project explorer so I would guess yes, CDT wants to have it also show in show in.
(In reply to Sarika Sinha from comment #4) > Will CDT user in debug perspective be interested in that? Yes. A common theme that I am seeing (and one that I follow myself) is to be in Debug perspective (virtually) all the time.
Sarika, can you tell me how can be contributed? As as got confirmation from Jonah that CDT wants it, we should add it especially as long term we plan to replace Package Explorer with Project Explorer.
Pierre-Yves, you seems to have work on a similar area before via https://git.eclipse.org/r/#/c/150213/8/org.eclipse.ui.workbench.texteditor/plugin.xml. Would you be interested in helping with this one?
(In reply to Lars Vogel from comment #7) > Sarika, can you tell me how can be contributed? > > As as got confirmation from Jonah that CDT wants it, we should add it > especially as long term we plan to replace Package Explorer with Project > Explorer. I don't have much idea about this.
(In reply to Lars Vogel from comment #8) > Pierre-Yves, you seems to have work on a similar area before via > https://git.eclipse.org/r/#/c/150213/8/org.eclipse.ui.workbench.texteditor/ > plugin.xml. Would you be interested in helping with this one? I'll try to have a look a it, probably not in the coming days/weeks though :)
Adding Alex, as he worked on a similar issue in Bug 550016. Alex, can you handle this bug as well?
Alex Blewitt, do you know / remember how to add Project Explorer to Open-With in the debug perspective? Would be nice to have this, but no one seems to know how to do this.
(In reply to Lars Vogel from comment #11) > Adding Alex, as he worked on a similar issue in Bug 550016. Alex, can you > handle this bug as well? Not sure I was involved with bug 550016 :) The implementation for (e.g.) Show In System Explorer is picked up by the handler: https://github.com/eclipse/eclipse.platform.ui/blob/master/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/handlers/ShowInSystemExplorerHandler.java That's referenced in the plugin.xml file with a command, handler, and menuContribution. https://github.com/eclipse/eclipse.platform.ui/blob/b78036673f090e2042afc4964a38556a197b7c76/bundles/org.eclipse.ui.ide/plugin.xml#L875-L880 https://github.com/eclipse/eclipse.platform.ui/blob/b78036673f090e2042afc4964a38556a197b7c76/bundles/org.eclipse.ui.ide/plugin.xml#L2391-L2399 https://github.com/eclipse/eclipse.platform.ui/blob/b78036673f090e2042afc4964a38556a197b7c76/bundles/org.eclipse.ui.ide/plugin.xml#L2185-L2200 The menu is visible when the condition referenced in the above is active: https://github.com/eclipse/eclipse.platform.ui/blob/b78036673f090e2042afc4964a38556a197b7c76/bundles/org.eclipse.ui.ide/plugin.xml#L2520-L2543 So I suspect something similar will be the case for the Show In Project Explorer view will be present, probably via the handler's visibleWhen condition.
So it turns out that this contribution isn't visible outside of the JDT perspective, because it's defined as a perspective extension of the JDT: https://github.com/eclipse/eclipse.jdt.ui/blob/a2b5e55566dae05a95328bae0209bb6f1ad966c3/org.eclipse.jdt.ui/plugin.xml#L611-L615
I suspect the easiest solution will be to evolve the showInProjectExplorer action to be a command instead, and then remove the showInPart contribution from the JDT so it doesn't show up twice.
(In reply to Alex Blewitt from comment #15) > I suspect the easiest solution will be to evolve the showInProjectExplorer > action to be a command instead, and then remove the showInPart contribution > from the JDT so it doesn't show up twice. Sounds great, Alex. Thanks for the investigation, for some reason I did not receive an email about for update, might be one of these times, in which the email server for the foundation had problems. Can you provide a Gerrit for this conversion?
