Community
Participate
Working Groups
Created attachment 283019 [details] new theme vs default system L&F on Linux (without theme) Follow up on bug 538740. I usually don't use themes, but just tried how it looks like with the new squared tabs. I see one major regression: the tabs have no separators drawn between them, this looks not nice. See attached screen shot with the default new UI L&F compared with "no themes" on Linux.
Thanks Andrey, looks like nobody noticed this in the M3 validation week. Mike, Andrew or Pierre-Yves, can you have a look?
I personally don't mind the lack of seperator's, but VSCode & Firefox do use tab seperators so we probably should do the same. I can most-likely contribute a patch, although Pierre-Yves or Mike might be able to do it faster (as improving the Maven language server is a top priority for me until 4.16 is released).
Hey Lars, I think the reason it was never noticed is because we've never had separators for tabs in the CTabRendering. I can try to have a look once I solve a regression that was introduced with the introduction of square tabs.
Mike, can you take this? I also think separators are nicer.
Mike, when you create a patch please add me as a reviewer :) And if you get caught up, I can try making a patch as well (once 4.16 is released) just let me know.
(In reply to Andrew Obuchowicz from comment #5) > Mike, when you create a patch please add me as a reviewer :) > > And if you get caught up, I can try making a patch as well (once 4.16 is > released) just let me know. +1
Mike, are you still planning to work on this?
I can try to take a crack at this over the next week or two.
(In reply to Mike Marchand from comment #8) > I can try to take a crack at this over the next week or two. Any update?
I will use some time this week to see what it'll take.
(In reply to Mike Marchand from comment #10) > I will use some time this week to see what it'll take. Any chance to have the patch for 4.17?
That was my goal. Unfortunately, with a loss in the family recently, I have not put the time into this that I had initially planned. I wanted to solve this in a way that the separators were optional, that way we could maintain the current look by tuning some CSS.
