Bug 563578 - Remove shell layout call after changing the topTrim visibility in WorkbenchWindow
Summary: Remove shell layout call after changing the topTrim visibility in WorkbenchWi...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.14   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-26 05:04 EDT by Lars Vogel CLA
Modified: 2020-05-28 16:19 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-05-26 05:04:40 EDT 
Rolf, indicated that the layout calls are now done correctly by the renderers so we should be able to remove such hacks.
Comment 1 Eclipse Genie CLA 2020-05-26 05:05:35 EDT 
New Gerrit change created: https://git.eclipse.org/r/163590
Comment 2 Rolf Theunissen CLA 2020-05-28 16:19:34 EDT 
(In reply to Lars Vogel from comment #0)
> Rolf, indicated that the layout calls are now done correctly by the
> renderers so we should be able to remove such hacks.

I indicated that layout calls *should* be done by the renderers, otherwise there will be UI issues in some scenarios. However, often (also in this case) the renderers do not handle the layout call correctly yet.