563555 – [GTK] Closing Shell shows annoying "is ready" popup on GNOME

Bug 563555 - [GTK] Closing Shell shows annoying "is ready" popup on GNOME

Summary: [GTK] Closing Shell shows annoying "is ready" popup on GNOME

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.16
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.17 M1
Assignee:	Alexandr Miloslavskiy
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2020-05-25 10:49 EDT by Alexandr Miloslavskiy
Modified:	2020-11-13 06:59 EST (History)
CC List:	3 users (show)

See Also:	371545 Gerrit Change Git Commit 565674 568550 Gerrit Change Gerrit Change Git Commit

Attachments
Repro snippet (1.62 KB, text/plain) 2020-05-25 10:58 EDT, Alexandr Miloslavskiy	no flags	Details
Video showing the problem (96.62 KB, image/gif) 2020-05-25 11:24 EDT, Alexandr Miloslavskiy	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexandr Miloslavskiy

2020-05-25 10:49:22 EDT

Comment 1 Alexandr Miloslavskiy

2020-05-25 10:58:17 EDT

Created attachment 283008 [details]
Repro snippet

Comment 2 Alexandr Miloslavskiy

2020-05-25 10:59:25 EDT

Reverting Bug 371545 solves this problem.

Comment 3 Alexandr Miloslavskiy

2020-05-25 11:24:20 EDT

Created attachment 283009 [details]
Video showing the problem

Comment 4 Alexandr Miloslavskiy

2020-05-25 12:53:47 EDT

I have tested on other Ubuntu versions:

20.04 - problem present
19.10 - problem present
18.10 - problem present
18.04 - good
16.04 - good

Comment 5 Alexandr Miloslavskiy

2020-05-25 14:35:00 EDT

I seem to have good results by removing `Shell#fixActiveShell()` completely. I expect to submit a patch tomorrow.

Comment 6 Eclipse Genie

2020-05-26 14:26:57 EDT

New Gerrit change created: https://git.eclipse.org/r/163633

Comment 7 Andrey Loskutov

2020-05-26 15:03:37 EDT

I think the code was so long there, we should not remove it in 4.16 (now in RC1). Please ping me once 4.17 starts.

Comment 8 Alexandr Miloslavskiy

2020-05-26 15:05:08 EDT

The problem is triggered by Bug 371545 which is rather recent.

Comment 9 Andrey Loskutov

2020-05-26 15:09:14 EDT

(In reply to Alexandr Miloslavskiy from comment #8)
> The problem is triggered by Bug 371545 which is rather recent.

But the code is removed by the patch is from 3.0 Eclipse...

Nothing against the patch, but shell focus / activation issues can be subtle, and having that in RC1 could make me nervous at least.

Comment 10 Alexandr Miloslavskiy

2020-05-26 15:09:47 EDT

ok

Comment 11 Alexandr Miloslavskiy

2020-06-08 11:12:12 EDT

@Andrey Loskutov it seems that 4.17 has started?

Comment 12 Andrey Loskutov

2020-06-09 05:45:46 EDT

(In reply to Alexandr Miloslavskiy from comment #11)
> @Andrey Loskutov it seems that 4.17 has started?

Yep, I've rebased your commit, and plan to merge today.

Comment 13 Eclipse Genie

2020-06-09 06:46:06 EDT

Gerrit change https://git.eclipse.org/r/163633 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=6371f380811160e02b570e6441e42938de3db6da

Comment 14 Alexandr Miloslavskiy

2020-06-09 06:48:15 EDT

Thanks!

Comment 15 Eclipse Genie

2020-11-05 07:25:08 EST

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/171810

Comment 16 Eclipse Genie

2020-11-13 05:04:08 EST

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/172195

Comment 17 Eclipse Genie

2020-11-13 06:59:47 EST

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/172195 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=2f7f7a8c8b0838357c0975aa340b0c39d6d83d6d