Bug 563384 - Duplicated classes for QuickDiff commands
Summary: Duplicated classes for QuickDiff commands
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.16   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-20 03:56 EDT by Thomas Wolf CLA
Modified: 2020-05-20 03:56 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wolf CLA 2020-05-20 03:56:41 EDT 
There are several duplicated classes relating to QuickDiff between bundles org.eclipse.ui.editors and org.eclipse.ui.workbench.texteditor.

* org.eclipse.ui.internal.editors.quickdiff
* org.eclipse.ui.internal.texteditor.quickdiff

Interesting is that these classes were originally in o.e.ui.editors. They then got moved to o.e.ui.workbench.texteditor in commits e551b7b8 and 42995157, and later re-introduced in o.e.ui.editors in commit 12d9623b ("get rid of internal imports").

The commits are from 2003/2004, and don't reference any bugzilla issue.

o.e.ui.editors does have a dependency on o.e.ui.workbench.texteditor.

Why is that code duplicated? We do have x-friends nowadays, so we could make the classes from the texteditor bundle visible selectively to the editor bundle. Was the code copied because at that time x-friends didn't exist?

What's going on there?