Bug 563331 - Update save icons to look good in dark and light theme as well as enabled / disabled
Summary: Update save icons to look good in dark and light theme as well as enabled / d...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.16   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-19 06:08 EDT by Lars Vogel CLA
Modified: 2022-02-08 03:57 EST (History)
5 users (show)

See Also:


Attachments
Screenshot (12.70 KB, image/png)
2020-05-19 06:08 EDT, Lars Vogel CLA
no flags Details
Screenshot (21.74 KB, image/png)
2020-05-28 06:07 EDT, Lars Vogel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-05-19 06:08:19 EDT
Created attachment 282925 [details]
Screenshot

Would be nice if the disabled save icons would look better. Maybe use more transparency in the icons?
Comment 1 Lars Vogel CLA 2020-05-19 06:08:49 EDT
Matthias, as master of all icons, can you give it a try to improve the icons?
Comment 2 Lars Vogel CLA 2020-05-22 07:50:05 EDT
I think Matthias improved Next Annotations / Previous Annotation icons a while ago. The same would be nice to have for Save and Save all.
Comment 3 Lars Vogel CLA 2020-05-28 06:07:06 EDT
Created attachment 283045 [details]
Screenshot

Using the free material icon for save looks good to me. 

WDYT?
Comment 4 Julian Honnen CLA 2020-05-28 06:21:43 EDT
Looks totally out of place to me. A flatter design style might be ok, but mixing monochrome shapes with the existing icons is weird.
Comment 5 Matthias Becker CLA 2020-05-28 06:39:31 EDT
(In reply to Julian Honnen from comment #4)
> Looks totally out of place to me. A flatter design style might be ok, but
> mixing monochrome shapes with the existing icons is weird.

Same for me.
Comment 6 Matthias Becker CLA 2020-05-28 06:40:24 EDT
(In reply to Julian Honnen from comment #4)
> Looks totally out of place to me. A flatter design style might be ok, but
> mixing monochrome shapes with the existing icons is weird.

Same for me.(In reply to Lars Vogel from comment #3)
> Created attachment 283045 [details]
> Screenshot
> 
> Using the free material icon for save looks good to me. 
> 
> WDYT?

To look sharp horizontal and vertical lines should be aligned at pixel borders (the page grid shown in your screenshot)
Comment 7 Lars Vogel CLA 2020-05-28 06:42:08 EDT
Matthias, once you find the time, maybe you can provide improved icons?
Comment 8 Matthias Becker CLA 2020-05-28 06:44:21 EDT
(In reply to Lars Vogel from comment #7)
> Matthias, once you find the time, maybe you can provide improved icons?

Which aspect should be improved?
Comment 9 Lars Vogel CLA 2020-05-28 06:46:34 EDT
(In reply to Matthias Becker from comment #8)
> (In reply to Lars Vogel from comment #7)
> > Matthias, once you find the time, maybe you can provide improved icons?
> 
> Which aspect should be improved?

IMHO the disabled icons look horrible in the dark theme. https://bugs.eclipse.org/bugs/attachment.cgi?id=282925
Comment 10 Matthias Becker CLA 2020-05-28 07:11:24 EDT
(In reply to Lars Vogel from comment #9)
> (In reply to Matthias Becker from comment #8)
> > (In reply to Lars Vogel from comment #7)
> > > Matthias, once you find the time, maybe you can provide improved icons?
> > 
> > Which aspect should be improved?
> 
> IMHO the disabled icons look horrible in the dark theme.
> https://bugs.eclipse.org/bugs/attachment.cgi?id=282925

horrible == to light??
Comment 11 Lars Vogel CLA 2020-05-28 07:13:51 EDT
(In reply to Matthias Becker from comment #10)
> (In reply to Lars Vogel from comment #9)
> > (In reply to Matthias Becker from comment #8)
> > > (In reply to Lars Vogel from comment #7)
> > > > Matthias, once you find the time, maybe you can provide improved icons?
> > > 
> > > Which aspect should be improved?
> > 
> > IMHO the disabled icons look horrible in the dark theme.
> > https://bugs.eclipse.org/bugs/attachment.cgi?id=282925
> 
> horrible == to light??

Yes, similar to the Toogle Word Wrap / Toogle Block selection items before you updated them.