Community
Participate
Working Groups
This would allow to simplify the usage of GTK css machinery, It became API in Gtk 3.20 so what we have for old versions is hope for the best behavior. This is crucial step to start prep work for upcoming Gtk 4 release.
New Gerrit change created: https://git.eclipse.org/r/159264
New Gerrit change created: https://git.eclipse.org/r/159269
Gerrit change https://git.eclipse.org/r/159264 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=0bd6474e4b257e49645b8086fbcae711f32581d8
New Gerrit change created: https://git.eclipse.org/r/159272
Gerrit change https://git.eclipse.org/r/159269 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=c5cd5196ce6d290ce29426b4d7e79435df4fcc4b
New Gerrit change created: https://git.eclipse.org/r/159274
Gerrit change https://git.eclipse.org/r/159272 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=593b5cd2a666c5f7e2b61577f5d656dab6306026
Gerrit change https://git.eclipse.org/r/159274 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ba57e916bdde950316ab777a277982b908cdd54c
This change breaks builds that do not have GTK 3.20.0. See <https://ci.eclipse.org/ocl/job/ocl-master/471/display/redirect> Bug 561784 raised.
(In reply to Ed Willink from comment #9) > This change breaks builds that do not have GTK 3.20.0. > > See <https://ci.eclipse.org/ocl/job/ocl-master/471/display/redirect> > > Bug 561784 raised. URL gives 502 so can't see it but based on the bug content you seem to be on old infrastructure. New infrastructure has 3.20+.
I'm putting your bug in see also instead of being blocker for swt.
(In reply to Alexander Kurtakov from comment #10) > New infrastructure has 3.20+. Good. > New infrastructure has 3.20+. Once again the very long migration time means that the old infrastructure kills me.
Should the minimal version in required in the Equinox launcher also have been increased? Now it seems to me that only a warning is logged, the user is not notified clearly. (From the current number of bugs flowing in, this makes at least one very unhappy user.) https://git.eclipse.org/c/equinox/rt.equinox.framework.git/tree/features/org.eclipse.equinox.executable.feature/library/gtk/eclipseGtkInit.c
Nota that this fix breaks Eclipse on Ubuntu 16.04 LTS (long term support version), at least in some places. I've had a report from a customer about the Location Browse button in the New Project wizard which cases a No more handles error: org.eclipse.swt.SWTError: No more handles at org.eclipse.swt.SWT.error(SWT.java:4749) at org.eclipse.swt.SWT.error(SWT.java:4638) at org.eclipse.swt.SWT.error(SWT.java:4609) at org.eclipse.swt.widgets.Dialog.error(Dialog.java:202) at org.eclipse.swt.widgets.DirectoryDialog.openNativeChooserDialog(Direc toryDialog.java:139) at org.eclipse.swt.widgets.DirectoryDialog.open(DirectoryDialog.java:123 ) at org.eclipse.ui.internal.ide.dialogs.ProjectContentsLocationArea.handl eLocationBrowseButtonPressed(ProjectContentsLocationArea.java:348) at org.eclipse.ui.internal.ide.dialogs.ProjectContentsLocationArea.acces s$7(ProjectContentsLocationArea.java:319) at org.eclipse.ui.internal.ide.dialogs.ProjectContentsLocationArea$2.wid getSelected(ProjectContentsLocationArea.java:223) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java: 252)
(In reply to Peter Severin from comment #14) > Nota that this fix breaks Eclipse on Ubuntu 16.04 LTS (long term support > version), at least in some places. I've had a report from a customer about > the Location Browse button in the New Project wizard which cases a No more > handles error: > > org.eclipse.swt.SWTError: No more handles > at org.eclipse.swt.SWT.error(SWT.java:4749) > at org.eclipse.swt.SWT.error(SWT.java:4638) > at org.eclipse.swt.SWT.error(SWT.java:4609) > at org.eclipse.swt.widgets.Dialog.error(Dialog.java:202) > at > org.eclipse.swt.widgets.DirectoryDialog.openNativeChooserDialog(Direc > toryDialog.java:139) > at > org.eclipse.swt.widgets.DirectoryDialog.open(DirectoryDialog.java:123 > ) > at > org.eclipse.ui.internal.ide.dialogs.ProjectContentsLocationArea.handl > eLocationBrowseButtonPressed(ProjectContentsLocationArea.java:348) > at > org.eclipse.ui.internal.ide.dialogs.ProjectContentsLocationArea.acces > s$7(ProjectContentsLocationArea.java:319) > at > org.eclipse.ui.internal.ide.dialogs.ProjectContentsLocationArea$2.wid > getSelected(ProjectContentsLocationArea.java:223) > at > org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java: > 252) See Bug 565607, there should have been a warning to the user.
Yes, it's a good idea, though there is no such warning in Eclipse 4.16, so it's just broken on Ubuntu 16.04. On the other hand is it wise to completely drop support for a still maintained distribution?
(In reply to Peter Severin from comment #16) > Yes, it's a good idea, though there is no such warning in Eclipse 4.16, so > it's just broken on Ubuntu 16.04. On the other hand is it wise to completely > drop support for a still maintained distribution? If more people landed a hand to fix bugs and etc. - probably not. With current amount of manpower and work on GTK 4.x starting - I fully stand behind the chnage.
