Bug 56095 - [RCP] setShow* methods have no effect after window is opened
Summary: [RCP] setShow* methods have no effect after window is opened
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2004-03-25 00:32 EST by Nick Edgar CLA
Modified: 2019-10-29 05:33 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2004-03-25 00:32:54 EST
build I20040324-0800

- changed the browser example to have View menu actions to toggle visibility of
the menubar, cool bar, perspective bar and status line using
IWorkbenchWindowConfigurer.setShow*
- only the menu bar action had any effect (though I couldn't test turning it
back on because the View menu went away <g>)
Comment 1 Nick Edgar CLA 2005-10-13 10:21:46 EDT
Kim, would you be able to have a look at this?

In 3.1 I made an (unreleased) patch which changed
    public void setShowCoolBar(boolean show) {
        showToolBar = show;
        // @issue need to be able to reconfigure after window's controls created
    }
to:
    public void setShowCoolBar(boolean show) {
    	if (show != showToolBar) {
    		showToolBar = show;
    		window.updateLayout(); 
    	}
    }

Likewise for setShowFastViewBars, setShowPerspectiveBar, setShowStatusLine and
setShowProgressIndicator.
But there have been subsequent changes here and I don't want to stomp on your toes.
Comment 2 Nick Edgar CLA 2005-10-20 10:39:10 EDT
This uses the following (new) method in WorkbenchWindow.

    /**
     * Updates the layout data for the default layout, and relays out the shell.
     * Note that this will only have an effect if the default implementation of
     * WorkbenchAdvisor.createWindowContents() has been invoked.
     */
    void updateLayout() {
        if (defaultLayout == null)
            return;
    	updateLayoutDataForContents();
    	if (getShell() != null && !getShell().isDisposed()) {
    		getShell().layout();
    	}
    }
Comment 3 Kim Horne CLA 2007-06-20 14:49:57 EDT
Boris, I'm inclined to close this as WONTFIX but will defer to you.
Comment 4 Boris Bokowski CLA 2009-11-26 16:15:18 EST
Prakash is now responsible for watching bugs in the [RCP] component area.
Comment 5 Eclipse Genie CLA 2019-04-19 17:34:18 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Lars Vogel CLA 2019-10-29 05:33:27 EDT
This bug is marked as stale for some time. If it is still relevant for the current release, please reopen and remove the stalebug whiteboard tag.