Bug 560667 - [regression] SelectionStatusDialog no longer shows OK status messages
Summary: [regression] SelectionStatusDialog no longer shows OK status messages
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.12   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.16 M1   Edit
Assignee: Alexander Fedorov CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-03-01 10:31 EST by Hernán González CLA
Modified: 2020-07-23 15:07 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hernán González CLA 2020-03-01 10:31:06 EST 
SelectionStatusDialog (org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/SelectionStatusDialog.java) used to display all Status messages (OK, WARNING, ERROR).

Now, after commit 32cc7517871fc53b393eef92fd104e230d07344f (Bug 546991 - [Dialogs] Extract MessageLine to a new public type ) it shows only WARNING/ERROR messages.

The problem is that org.eclipse.ui.internal.MessageLine.java was replaced by org.eclipse.jface/src/org/eclipse/jface/dialogs/MessageLine.java, but they have different behaviours.

The former showed all messages (see method setErrorStatus in 
https://git.eclipse.org/r/plugins/gitiles/platform/eclipse.platform.ui/+/f3ea6a3368796759bced54585d25fb5605a081a3/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/MessageLine.java ) while the latter does not show OK status messages (see https://github.com/eclipse/eclipse.platform.ui/blob/master/bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/MessageLine.java )
Comment 1 Andrey Loskutov CLA 2020-03-01 10:38:41 EST 
Alexander, could you please check?
Comment 2 Alexander Fedorov CLA 2020-03-01 10:42:17 EST 
(In reply to Andrey Loskutov from comment #1)
> Alexander, could you please check?

Yes, it looks like IStatus with OK severity will not have message applied by the new impl. 
The method contract is really unclear, but I think now we need to restore the implementation.
Comment 3 Eclipse Genie CLA 2020-03-01 12:30:38 EST 
New Gerrit change created: https://git.eclipse.org/r/158638
Comment 4 Alexander Fedorov CLA 2020-03-01 12:34:10 EST 
(In reply to Eclipse Genie from comment #3)
> New Gerrit change created: https://git.eclipse.org/r/158638

Andrey, could you please review?
Comment 5 Hernán González CLA 2020-03-13 07:19:43 EDT 
Is there some target milestone for this or estimate? 
It's hitting our RCP product and we need to decide if we wait for the fix or devise some workaround.
Comment 7 Alexander Fedorov CLA 2020-03-16 09:10:51 EDT 
(In reply to Hernán González from comment #5)
> Is there some target milestone for this or estimate? 
> It's hitting our RCP product and we need to decide if we wait for the fix or
> devise some workaround.

Please try it in the nearest integration build
Comment 8 Eclipse Genie CLA 2020-03-18 16:42:02 EDT 
New Gerrit change created: https://git.eclipse.org/r/159669