Bug 560415 - Get rid of 'Activate bundle for 'File content' proposals'
Summary: Get rid of 'Activate bundle for 'File content' proposals'
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.15   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 551970
Blocks:
  Show dependency tree
 
Reported: 2020-02-22 08:28 EST by Dani Megert CLA
Modified: 2020-04-06 10:20 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2020-02-22 08:28:42 EST
There should be no need for that. Almost all users will muss that feature unless they read the N&N.
Comment 1 Dani Megert CLA 2020-02-22 08:33:27 EST
Would be nice to have a user-friendly solution for 4.15.
Comment 2 Mickael Istria CLA 2020-02-23 16:38:49 EST
We'd need to activate the quicksearch bundle automtically, either at startup or when loading the Quick Access. Would that be acceptable?
Comment 3 Dani Megert CLA 2020-03-15 12:24:21 EDT
(In reply to Mickael Istria from comment #2)
> We'd need to activate the quicksearch bundle automtically, either at startup
> or when loading the Quick Access. Would that be acceptable?
When Quick Search is opened it's fine with me to load the contributions.
Comment 4 Mickael Istria CLA 2020-03-19 10:21:41 EDT
(In reply to Dani Megert from comment #3)
> When Quick Search is opened it's fine with me to load the contributions.

I interpret (maybe erroneously) that in bug 546187 comment 17 and bug 546187 comment 28 you had a different opinion about when to load contributions. It's fine if you changed your mind, I'd be glad to enable all the contributors when users hits Ctrl+3 and get rid of the "Activate" entry and impression of missing content when some bundles are not active.
Please confirm you're OK to change the behavior to more "greedy" plugin activation, and I'll apply that. If so, the test in bug 547001 would also need to be reworked (but nothing difficult here I believe).
Comment 5 Dani Megert CLA 2020-04-06 06:34:19 EDT
(In reply to Mickael Istria from comment #4)
> (In reply to Dani Megert from comment #3)
> > When Quick Search is opened it's fine with me to load the contributions.
> 
> I interpret (maybe erroneously) that in bug 546187 comment 17 and bug 546187
> comment 28 you had a different opinion about when to load contributions.
> It's fine if you changed your mind, I'd be glad to enable all the
> contributors when users hits Ctrl+3 and get rid of the "Activate" entry and
> impression of missing content when some bundles are not active.
> Please confirm you're OK to change the behavior to more "greedy" plugin
> activation, and I'll apply that. If so, the test in bug 547001 would also
> need to be reworked (but nothing difficult here I believe).
Sorry for the late response.

What's the footprint of those extensions? Where is e.g. the File Content code located?

Independent of that, auto-loading will have the problem that users can't disable it at the moment. There would have to be a preference where I can disable e.g. File Content proposals.
Comment 6 Mickael Istria CLA 2020-04-06 08:09:36 EDT
(In reply to Dani Megert from comment #5)
> the File Content
> code located?

in org.eclipse.text.quicksearch.

> Independent of that, auto-loading will have the problem that users can't
> disable it at the moment. There would have to be a preference where I can
> disable e.g. File Content proposals.

Ok, can you please open the ticket about disabling and preferences and mark it as a requirement?
Comment 7 Dani Megert CLA 2020-04-06 10:20:20 EDT
I looked at this again and auto-starting would be bad for e.g. a new workspace. There we would for example load the Debug plug-ins.

Closing for now until we have a better solution.