560324 – [ELK] The preference "Move unlinked notes during layout" is not considered by ELK

Bug 560324 - [ELK] The preference "Move unlinked notes during layout" is not considered by ELK

Summary: [ELK] The preference "Move unlinked notes during layout" is not considered by...

Status:	RESOLVED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Diagram (show other bugs)
Version:	unspecified
Hardware:	PC Windows 10

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Laurent Redor
QA Contact:

URL:
Whiteboard:
Keywords:	triaged

Depends on:	560323 560453
Blocks:
	Show dependency tree

Reported:	2020-02-19 11:02 EST by Laurent Redor
Modified:	2020-03-15 16:01 EDT (History)
CC List:	1 user (show)

See Also:	Gerrit Change Gerrit Change Git Commit Git Commit

Attachments
TestElkLayout.zip (5.57 KB, application/x-zip-compressed) 2020-02-19 11:02 EST, Laurent Redor	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Laurent Redor

2020-02-19 11:02:33 EST

Created attachment 281864 [details]
TestElkLayout.zip

This issue depends on bug 560323 - [ELK] Do not launch the Sirius post treatment for pinned elements after an "Arrange" that uses ELK layout. It must be fixed before this new one.

Steps to reproduce:
* Import project TestElkLayout from TestElkLayout.zip
* Open preference page "Sirius/Sirius Diagram"
* Check preference "Move unlinked notes during layout"
* Open diagram "simpleDiagramWithNote"
* Launch an "Arrange All"
* Expected: The diagram is layouted and the note is moved.
* Undo (the arrange)
* Open preference page "Sirius/Sirius Diagram"
* Uncheck preference "Move unlinked notes during layout"
* Launch an "Arrange All"
* Expected: The diagram is layouted and the note is not moved. MyClass4 overlaps the Note.

Comment 1 Eclipse Genie

2020-02-27 13:17:53 EST

New Gerrit change created: https://git.eclipse.org/r/158529

Comment 2 Eclipse Genie

2020-02-27 13:17:56 EST

New Gerrit change created: https://git.eclipse.org/r/158530

Comment 3 Eclipse Genie

2020-03-15 15:55:53 EDT

Gerrit change https://git.eclipse.org/r/158529 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=28873ca47b5f543a343770e36686e87b5ab66264

Comment 4 Eclipse Genie

2020-03-15 15:55:54 EDT

Gerrit change https://git.eclipse.org/r/158530 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3241a08b28884e61ad29fca5db184ad269848dcf

Comment 5 Laurent Redor

2020-03-15 16:01:23 EDT

Steps to validate:
* See Steps to reproduce in description (comment 0)