Bug 560323 - [ELK] Do not launch the Sirius post treatment for pinned elements after an "Arrange" that uses ELK layout
Summary: [ELK] Do not launch the Sirius post treatment for pinned elements after an "A...
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 6.4.0   Edit
Assignee: Laurent Redor CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on: 568037
Blocks: 560324
  Show dependency tree
 
Reported: 2020-02-19 10:55 EST by Laurent Redor CLA
Modified: 2020-12-04 04:23 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2020-02-19 10:55:45 EST 
The Sirius post treatment for pinned elements, PinnedElementsLayoutProvider, is not compatible with ELK Layout. Currently if some elements are pinned, after an arrange all using ELK, Sirius launches this post treatment and it breaks the ELK result.

The user must unpin all pinned elements before launching an arrange all using ELK to have "good" result.

The goal of this issue is to not launch post treatment for pinned elements when the arrange is managed by ELK.
Comment 1 Eclipse Genie CLA 2020-02-27 13:17:39 EST 
New Gerrit change created: https://git.eclipse.org/r/158526
Comment 2 Laurent Redor CLA 2020-03-14 13:59:32 EDT 
The test org.eclipse.sirius.tests.unit.diagram.layout.SimpleELKLayoutTest.testNoteLayoutWithPrefFalse() should be activated as soon as this bug will be fixed.
Comment 3 Laurent Redor CLA 2020-10-21 03:06:17 EDT 
The resolution of bug 568037 also fixes this problem. Indeed with gerrit 171012 [1]. The standard selection mechanism is no longer used for ELK layout (and also the "pinned" aspect of this mechanism).

Only one commit will be added for this issue : 
* Activation of SimpleELKLayoutTest.testNoteLayoutWithPrefFalse() (as explain in above comment)
* Additional test to ensure that the layout result is the same for a diagram with pinned elements and without pinned elements.

The current behavior is that "pinned" elements are ignogred during ELK layout. They are not considered as "pinned" by ELK.

Maybe a further enhancement will be to support "pinned" elements with ELK layout.

[1] https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171012
Comment 4 Eclipse Genie CLA 2020-10-21 03:54:42 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/171038
Comment 6 Laurent Redor CLA 2020-11-06 05:05:02 EST 
Steps to validate:
* Launch an arrange all using ELK with and without pinned elements.
* Expected: The result is the same with and without pinned elements.
Comment 7 Pierre-Charles David CLA 2020-12-04 04:23:12 EST 
Available in Sirius 6.4.0, see https://download.eclipse.org/sirius/updates/releases/6.4.0/ for details.