Bug 560276 - Broken / wrong ordered debug toolbar
Summary: Broken / wrong ordered debug toolbar
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.15   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.15 M3   Edit
Assignee: Rolf Theunissen CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-02-18 08:18 EST by Paul Pazderski CLA
Modified: 2020-02-19 03:35 EST (History)
5 users (show)

See Also:

Attachments
Broken and correct toolbar order (11.13 KB, image/png)
2020-02-18 08:18 EST, Paul Pazderski CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Pazderski CLA 2020-02-18 08:18:10 EST 
Created attachment 281850 [details]
Broken and correct toolbar order

See attached screenshot. Since I20200217-1800 the step buttons of debug toolbar are moved to the right, in reverse order and all separated with a bar.

The similar toolbar which can be shown in Debug View is still correct.

This seem to be related to bug 560199. Without that change the toolbar has its old /correct state.
Comment 1 Andrey Loskutov CLA 2020-02-18 08:31:01 EST 
Rolf, this must be fixed for 4.15. I believe the order didn't change for ages.
Comment 2 Rolf Theunissen CLA 2020-02-18 09:04:34 EST 
The issue is caused by group-markers that have an attribute toBeRendered false, they should only be invisible.
Comment 3 Eclipse Genie CLA 2020-02-18 09:09:59 EST 
New Gerrit change created: https://git.eclipse.org/r/157902
Comment 4 Matthias Becker CLA 2020-02-18 09:30:53 EST 
(In reply to Rolf Theunissen from comment #2)
> The issue is caused by group-markers that have an attribute toBeRendered
> false, they should only be invisible.

Which change did cause this regression?
Comment 5 Rolf Theunissen CLA 2020-02-18 09:34:16 EST 
(In reply to Matthias Becker from comment #4)
> (In reply to Rolf Theunissen from comment #2)
> > The issue is caused by group-markers that have an attribute toBeRendered
> > false, they should only be invisible.
> 
> Which change did cause this regression?

https://git.eclipse.org/r/#/c/157779/

With this change the ToolbarManagerRenderer ignores not to be rendered items the same way as the MenuManagerRenderer ignores them. Ignoring the items is the correct way to handle them.
Comment 6 Lars Vogel CLA 2020-02-18 10:14:45 EST 
(In reply to Eclipse Genie from comment #3)
> New Gerrit change created: https://git.eclipse.org/r/157902

I suggest to merge this fix for M3.
Comment 8 Paul Pazderski CLA 2020-02-18 10:55:36 EST 
Thanks for the quick fix Rolf! That disorder was annoying; or the right opportunity to more often use the keys :)
Comment 9 Lars Vogel CLA 2020-02-18 10:56:57 EST 
Rolfs toolbar and menu work reveals lots of old and hidden bugs in the code.
Thanks, Rolf for working on this task.
Comment 10 Paul Pazderski CLA 2020-02-19 03:35:17 EST 
verified in I20200218-1800