Bug 560162 - GridLayout does not handle GridData.exclude correctly
Summary: GridLayout does not handle GridData.exclude correctly
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.15   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-14 11:26 EST by Patrick Tasse CLA
Modified: 2020-02-14 11:26 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Tasse CLA 2020-02-14 11:26:00 EST 
In GridLayout.layout(), a Control[] of children is built.

Any Control that has GridData.exclude==true is removed from this array, the subsequent controls are shifted down in the array, and the count is decremented.

But later when building the Control[][] grid, this exclusion is not taken into account.

So if the first Control in row 0, column 0 is excluded, then in the grid the Control in row 0, column 1 takes its place, and this second Control's layout data is used for the purposes of layout of the column 0.

Things do not end well.