Bug 560134 - Update close button on tab to something nicer
Summary: Update close button on tab to something nicer
Status: CLOSED DUPLICATE of bug 501491
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.14   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-14 02:32 EST by Lars Vogel CLA
Modified: 2020-05-26 05:33 EDT (History)
2 users (show)

See Also:

Attachments
Screenshot (54.51 KB, image/png)
2020-02-14 02:32 EST, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-02-14 02:32:07 EST 
Created attachment 281817 [details]
Screenshot

The software drawn close button in Eclipse does not look good compared to other editors as for example code. This is especially true for low resolutions. Also the close button on the tab is not consistent with the close button for the Eclipes application.

I suggest we adapt a similar button as VsCode to look better and more consistent. This will also allow us to leverage the research for the UI designers at Microsoft.
Comment 1 Lars Vogel CLA 2020-02-14 02:33:13 EST 
Matthias, what do you think? Would you be able to help with a new icon?
Comment 2 Alexander Kurtakov CLA 2020-02-14 02:52:32 EST 
We have close button icon. I have used it in https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=d5142ba754dc34181e6a4939a5629b821a8e0d2e . Why not use this one?
Comment 3 Lars Vogel CLA 2020-02-14 03:02:47 EST 
(In reply to Alexander Kurtakov from comment #2)
> We have close button icon. I have used it in
> https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/
> ?id=d5142ba754dc34181e6a4939a5629b821a8e0d2e . Why not use this one?

Makes sense to use the same icon. But eclipse.platform.ua/org.eclipse.help.ui/icons/elcl16/close.png seems to use only dark, which would not fix the dark theme. The icon of VScode seems usable in both ligth and dark theme.
Comment 4 Lars Vogel CLA 2020-02-18 04:22:48 EST 
Microsoft icon repo: https://github.com/microsoft/vscode-icons
Comment 5 Matthias Becker CLA 2020-02-19 03:38:28 EST 
(In reply to Lars Vogel from comment #3)
> (In reply to Alexander Kurtakov from comment #2)
> > We have close button icon. I have used it in
> > https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/
> > ?id=d5142ba754dc34181e6a4939a5629b821a8e0d2e . Why not use this one?
> 
> Makes sense to use the same icon. But
> eclipse.platform.ua/org.eclipse.help.ui/icons/elcl16/close.png seems to use
> only dark, which would not fix the dark theme. The icon of VScode seems
> usable in both ligth and dark theme.

As far as I see they use different SVGs on light and dark theme.
Comment 6 Lars Vogel CLA 2020-05-26 05:33:16 EDT 

*** This bug has been marked as a duplicate of bug 501491 ***