Description Andrey Loskutov 2020-01-27 10:50:41 EST

We have now found the case where the patch for bug 540253 in SourceLookupService makes a "custom debug view" use case not work as expected.

In our product we use both Debug and "custom debug" views to control debugger execution. We have our own DebugContextProvider that adds itself to org.eclipse.debug.ui.contexts.IDebugContextService.addDebugContextProvider(IDebugContextProvider) and specifies via org.eclipse.debug.ui.contexts.AbstractDebugContextProvider.getPart() which view is related to the debug context / DebugContextEvent events.

If our "custom" debug view is open (and default Debug view closed), and breakpoint is hit, we want that the debugger opens the related editor and highlights the related line in the source, as if Debug view would be opened. 

This doesn't work now due the patch for bug 540253 and bug 538548, see  https://git.eclipse.org/r/#/c/131127/6/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/sourcelookup/SourceLookupService.java@72 .

In SourceLookupService.debugContextChanged(DebugContextEvent) we check isDebugViewActive() only for the "concrete" instance of the LaunchView being active, but we should check if the instance provided via DebugContextEvent.getDebugContextProvider().getPart() is active (*if* there is one of course, and only after that for the LaunchView).

This wasn't noticed yet because usually default Debug view is always opened in Debug perspective, but if user closes it, the bug happens.

I will push the patch.