Bug 559319 - Enhance configuration options for inline problem markers to work better with unfinished code
Summary: Enhance configuration options for inline problem markers to work better with ...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.14   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-18 14:25 EST by Erik Brangs CLA
Modified: 2020-02-16 08:02 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Brangs CLA 2020-01-18 14:25:26 EST
I tried out the inline problem markers from Eclipse 4.14 when doing Java development. I found that I'd really like to have the markers for warnings, e.g. when I'm cleaning up code.

However, the problem markers are also displayed for errors and this don't seem to play well with the incremental compilation and my development. Generally, errors are displayed while I'm still not finished with the part I'm working on. This is fine for markers on the side of the editor or in the problem view but the inline markers for errors are very annoying in this case.

I would like to have a way to have inline problem markers enabled but not have them displayed for errors that occur while I'm still editing the code.

I suppose there are several ways to achieve this. For me, it would be sufficient to just not display inline problem markers for errors at all but this currently can't be configured in the GUI.
Comment 1 Mickael Istria CLA 2020-01-23 04:18:23 EST
In bug 553849 comment 10, Niko explains that it's technically doable as the property is a bit-misk. So replacing the combo box by some checkboxes (one for each severity) could do the trick.
Comment 2 Niko Stotz CLA 2020-01-26 17:11:42 EST
We had some discussions about the settings UI at https://git.eclipse.org/r/#/c/142835/11/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/internal/texteditor/codemining/annotation/AnnotationCodeMiningPreferenceConstants.java@42. The original implementation were checkboxes; after the discussion we settled on the current dropdown.

We can change it, but first should have an agreement.
Comment 3 Mickael Istria CLA 2020-01-26 18:16:41 EST
(In reply to Niko Stotz from comment #2)
> We had some discussions about the settings UI at
> https://git.eclipse.org/r/#/c/142835/11/org.eclipse.ui.workbench.texteditor/
> src/org/eclipse/ui/internal/texteditor/codemining/annotation/
> AnnotationCodeMiningPreferenceConstants.java@42. The original implementation
> were checkboxes; after the discussion we settled on the current dropdown.
> 
> We can change it, but first should have an agreement.

The discussion took place before this issue arose, so it's mostly outdated.
Note that this issue is not really about the configuration, but really more about error code minings appearing too soon.
Maybe instead of more configration, what users really want is that error code minings get shown only when document is not dirty.
Comment 4 Erik Brangs CLA 2020-02-16 08:02:09 EST
As described in bug 553849 comment 10, I edited the property for showing inline markers to not show markers on errors. However, the property kept getting overwritten by the preference recorder. It worked fine after I edited the property via the preference recorder GUI.

I've tried it out for a while and not showing problem markers on errors is much better. Still, I think there is further room for improvement. There are still some less annoying markers that appear during code editing (e.g. warnings about unused variables).

Is it likely that some improvements for this will land in one of the next releases? Even having a better GUI for configuring inline markers (e.g. the mentioned checkboxes) would be a good start.