559298 – skipAPIAnalysis is enabled for some platform bundles

Bug 559298 - skipAPIAnalysis is enabled for some platform bundles

Summary: skipAPIAnalysis is enabled for some platform bundles

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	Releng (show other bugs)
Version:	4.15
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.15 M3
Assignee:	Andrey Loskutov
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2020-01-17 08:16 EST by Andrey Loskutov
Modified:	2020-01-22 10:04 EST (History)
CC List:	1 user (show)

See Also:	Gerrit Change Gerrit Change Gerrit Change 474156 Git Commit Git Commit Git Commit Gerrit Change Git Commit 559418

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrey Loskutov

2020-01-17 08:16:38 EST

Found on occasion by working on bug 543363.

Looks like we've missed to remove skipAPIAnalysis flag from few bundles after fixing bug 474156.

Currently I see it enabled for:

org.eclipse.core.filesystem.linux.x86_64
org.eclipse.e4.emf.xpath.test
org.eclipse.e4.ui.progress
org.eclipse.e4.ui.swt.gtk
org.eclipse.jface.snippets
org.eclipse.jface.tests
org.eclipse.swt.tests.gtk
org.eclipse.text.quicksearch.tests

We should remove this flag from all pom.xml files in platform.

Comment 1 Eclipse Genie

2020-01-17 08:48:28 EST

New Gerrit change created: https://git.eclipse.org/r/156088

Comment 2 Eclipse Genie

2020-01-17 08:49:11 EST

New Gerrit change created: https://git.eclipse.org/r/156089

Comment 3 Eclipse Genie

2020-01-17 08:50:23 EST

New Gerrit change created: https://git.eclipse.org/r/156090

Comment 4 Eclipse Genie

2020-01-17 09:28:14 EST

Gerrit change https://git.eclipse.org/r/156090 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=63a1a7bfecb978f1cbd937bcbb13b837c8828162

Comment 5 Eclipse Genie

2020-01-17 09:28:15 EST

Gerrit change https://git.eclipse.org/r/156089 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=8793935e231af7b4e532f41d7df7e58fe1c9a99d

Comment 6 Eclipse Genie

2020-01-17 12:51:04 EST

Gerrit change https://git.eclipse.org/r/156088 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=048eefc45daa5e404201a741c8c042233deae666

Comment 7 Eclipse Genie

2020-01-22 08:50:56 EST

New Gerrit change created: https://git.eclipse.org/r/156336

Comment 8 Eclipse Genie

2020-01-22 09:58:04 EST

Gerrit change https://git.eclipse.org/r/156336 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=e78727f0dc0b653b9d5b37cfd6f145f6dfc1a4fc

Comment 9 Andrey Loskutov

2020-01-22 10:04:04 EST

Removed the flag for:

org.eclipse.core.filesystem.linux.x86_64
org.eclipse.swt.tests.gtk
org.eclipse.e4.ui.swt.gtk
org.eclipse.jface.tests
org.eclipse.text.quicksearch.tests

Following bundles seem not to be "visible" to API analysis for whatever reason:

> org.eclipse.e4.emf.xpath.test
> org.eclipse.e4.ui.progress
> org.eclipse.jface.snippets

I guess the way they are setup/buit/deployed differs, don't have time/knowledge to continue here. I've opened dedicated ticket for them, see bug 559418.