Bug 559037 - Support bare hyperlinks (without delimiters) in markdown
Summary: Support bare hyperlinks (without delimiters) in markdown
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.36   Edit
Assignee: Max Bureck CLA
QA Contact: David Green CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 558573
  Show dependency tree
 
Reported: 2020-01-10 12:07 EST by Max Bureck CLA
Modified: 2020-02-12 20:29 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max Bureck CLA 2020-01-10 12:07:28 EST
Similar to GitHub flavor's autolink extension (https://github.github.com/gfm/#extended-autolink-path-validation) the "org.eclipse.mylyn.wikitext.markdown" plugin should support automatic detection of URLs without the need of '<' and '>' delimiters. A similar feature is already implemented for the CommonMark bundle (see bug 468900). Since this can only be done via a heuristic, the feature should probably only be an optional one, one can opt-in on the level of org.eclipse.mylyn.wikitext.markdown.MarkdownLanguage.

Background:
This feature was requested by a user of Eclipse Corrosion (https://github.com/eclipse/corrosion/issues/277). Corrosion is based on LSP4E, which uses the MarkupParser with MarkdownLanguage to show Markdown as HTML in Hovers.

I have a commit ready (as a start of a discussion) that I will push to Gerrit soon. It is closer to GitHub flavored Mardkown than the implementation in the CommonMark bundle.
Comment 1 Eclipse Genie CLA 2020-01-10 12:19:12 EST
New Gerrit change created: https://git.eclipse.org/r/155621
Comment 2 Max Bureck CLA 2020-01-18 16:34:01 EST
Is there anything that can be done to help  reviewers? If more documentation/explanation is needed or I should manually test something, let me know. I understand if committers maybe don't have time at the moment or there is a feature freeze or something. Just if there is something I can help with to make progress on the issue, let me know.
Comment 4 Torkild Resheim CLA 2020-01-20 09:58:36 EST
Thanks Max! This looks like a nice new feature.
Comment 5 Max Bureck CLA 2020-01-21 08:29:14 EST
Thanks for accepting the contribution! Is there already a roadmap when the next Mylyn Docs release is scheduled? The governance page does not show a planned upcoming release: https://projects.eclipse.org/projects/mylyn.docs/governance

It would be great if releases of the downstream projects LSP4E and Corrosion can be planned accordingly to incorporate the chance as well.
Comment 6 Pierre-Yves Bigourdan CLA 2020-01-22 14:45:21 EST
(In reply to Max Bureck from comment #5)
> Thanks for accepting the contribution! Is there already a roadmap when the
> next Mylyn Docs release is scheduled? The governance page does not show a
> planned upcoming release:
> https://projects.eclipse.org/projects/mylyn.docs/governance
> 
> It would be great if releases of the downstream projects LSP4E and Corrosion
> can be planned accordingly to incorporate the chance as well.

If I'm not mistaken, Mylyn Docs releases generally happen just before the Eclipse Simrels.