Bug 558958 - [E4] Class name filter not working in "Find Contribution Class" dialog
Summary: [E4] Class name filter not working in "Find Contribution Class" dialog
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.15   Edit
Hardware: PC Windows 10
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Benedikt Kuntz CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-09 04:24 EST by Sravan Kumar Lakkimsetti CLA
Modified: 2020-06-01 03:47 EDT (History)
4 users (show)

See Also:

Attachments
Screenshot (20.62 KB, image/png)
2020-01-09 04:24 EST, Sravan Kumar Lakkimsetti CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sravan Kumar Lakkimsetti CLA 2020-01-09 04:24:11 EST 
Created attachment 281424 [details]
Screenshot

Class name filter stops working once a special character is added(ex . /)

Steps to reproduce
1. create a e4 RCP app
2. open application.e4xmi
3. add a new addon
4. click find button against class url
5. in the Find Contribution Class dialog enter "org." 

after typing . results vanish

If this is not from platform ui please move appropriately
Comment 1 Lars Vogel CLA 2020-01-09 04:34:05 EST 
Benedikt, can you take this one?
Comment 2 Eclipse Genie CLA 2020-01-09 10:34:29 EST 
New Gerrit change created: https://git.eclipse.org/r/155550
Comment 3 Benedikt Kuntz CLA 2020-01-09 10:42:36 EST 
Some comments to the Gerrit: This only fixes the issue when having Workspace or Target Platform selected as search scope. Then, TargetPlatformClassContributionCollector is used. Within this class, I added two changes: When loading the classes, the package names of the classes are derived from its file path, but the code assumed unix path seperators.
Also, the package name was not considered in the pattern matching.
When selecting Project as scope, PDEClassContributionProvider is used, there should be another Gerrit for that class...
Comment 4 Alexander Kurtakov CLA 2020-06-01 03:47:39 EDT 
Too late for 4.16.