Bug 558905 - Comparator error in I20200108-0025
Summary: Comparator error in I20200108-0025
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.15   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.15 M1   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-08 02:55 EST by Noopur Gupta CLA
Modified: 2020-01-08 04:40 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2020-01-08 02:55:38 EST 
https://download.eclipse.org/eclipse/downloads/drops4/I20200108-0025/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt

Comparator differences from current build
	/shared/eclipse/builds/4I/siteDir/eclipse/downloads/drops4/I20200108-0025
compared to reference repo at 
	https://download.eclipse.org/eclipse/updates/4.15-I-builds

1.  eclipse.platform.ui/bundles/org.eclipse.ui.workbench
   no-classifier: different
      org/eclipse/ui/internal/quickaccess/QuickAccessExtensionManager$QuickAccessProviderExtensionProxy.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [pack200, sources]
Comment 1 Andrey Loskutov CLA 2020-01-08 03:05:04 EST 
This is related to the bug 558642 comment 16, commit https://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=4c7d63e115c486d331728fa0396ab2665e29d578.

SafeRunner from org.eclipse.equinox.common was reverted, so recompile of QuickAccessExtensionManager changed the class file without changes on org.eclipse.ui.workbench bundle itself.

I don't know what is the right solution, maven should be told to keep the new version of org.eclipse.ui.workbench and do not replace it with the baseline.
Comment 2 Eclipse Genie CLA 2020-01-08 03:12:46 EST 
New Gerrit change created: https://git.eclipse.org/r/155449