Bug 558656 - URLHyperlinkDetector includes trailing . in URL
Summary: URLHyperlinkDetector includes trailing . in URL
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.15   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 4.21 M1   Edit
Assignee: Thomas Wolf CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2019-12-27 16:11 EST by Jonah Graham CLA
Modified: 2021-06-10 13:03 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonah Graham CLA 2019-12-27 16:11:09 EST 
A URL of the form:

    https://www.eclipse.org/downloads.

includes the . in the URL/region.

While the . is a legal URI character, it means that URLs at the end of a sentence are detected incorrectly. 

I have compared this behaviour to gmail, VSCode and my terminal which all exclude this trailing .
Comment 1 Thomas Wolf CLA 2021-06-10 05:17:52 EDT 
What if there is other punctuation following? Like ',' or ';'? Should those be excluded, too? What about "?"?
Comment 2 Andrey Loskutov CLA 2021-06-10 05:22:45 EDT 
(In reply to Thomas Wolf from comment #1)
> What if there is other punctuation following? Like ',' or ';'? Should those
> be excluded, too? What about "?"?

Probably not exclude for all above. I think filtering trailing dot should be enough here.
Comment 3 Eclipse Genie CLA 2021-06-10 07:26:02 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181769
Comment 5 Mickael Istria CLA 2021-06-10 13:03:16 EDT 
Thanks Thomas!