Bug 558395 - Workspace Launcher input does not scroll to the right when typing a long path
Summary: Workspace Launcher input does not scroll to the right when typing a long path
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.13   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-17 06:00 EST by Lukas Lieb CLA
Modified: 2021-04-16 13:27 EDT (History)
3 users (show)

See Also:


Attachments
Write long workspace (33.77 KB, image/png)
2019-12-17 06:00 EST, Lukas Lieb CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lukas Lieb CLA 2019-12-17 06:00:28 EST
Created attachment 281254 [details]
Write long workspace

If start a new eclipse (or switch the workspace), the Workspace Launcher will be opened. If you want now to set manually a long path for your workspace, the windows version stuck at the beginning of the field. Means you can not see what you are tipping.
Comment 1 Lars Vogel CLA 2019-12-17 08:26:38 EST
Lukas, could you provide a Gerrit for fix that?
Comment 2 Lars Vogel CLA 2019-12-17 08:28:45 EST
Class to be modified would most likely be:

/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/ChooseWorkspaceDialog.java

in Git repo listed here: https://git.eclipse.org/r/#/admin/projects/platform/eclipse.platform.ui
Comment 3 Dani Megert CLA 2019-12-17 08:29:38 EST
(In reply to Lars Vogel from comment #1)
> Lukas, could you provide a Gerrit for fix that?
You have to add him to cc or assign ;-)
Comment 4 Lars Vogel CLA 2019-12-17 08:55:25 EST
(In reply to Dani Megert from comment #3)
> (In reply to Lars Vogel from comment #1)
> > Lukas, could you provide a Gerrit for fix that?
> You have to add him to cc or assign ;-)

;-) Lukas reported the bug, so no need to cc him.
Comment 5 Dani Megert CLA 2019-12-17 09:39:05 EST
(In reply to Lars Vogel from comment #4)
> (In reply to Dani Megert from comment #3)
> > (In reply to Lars Vogel from comment #1)
> > > Lukas, could you provide a Gerrit for fix that?
> > You have to add him to cc or assign ;-)
> 
> ;-) Lukas reported the bug, so no need to cc him.
I see.
Comment 6 Tony Homer CLA 2021-04-16 12:57:55 EDT
This behavior was reported to me in a downstream Eclipse product.
I am not able to reproduce it on Linux.

(Lukas Lieb in comment #0)
> workspace, the windows version stuck at the beginning of the field. Means

As I think Lukas was saying, this seems to be specific to Windows.
Comment 7 Tony Homer CLA 2021-04-16 13:13:22 EDT
I took a quick look through the class suggested by Lars in comment #2.
https://github.com/eclipse/eclipse.platform.ui/blob/master/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/ChooseWorkspaceDialog.java

Nothing jumps out to me as controlling the caret/cursor position and scrolling of the text Combo (which is where the user types in the workspace path).

My guess is that this is a bug in SWT Combo for Windows:
https://github.com/eclipse/eclipse.platform.swt/blob/master/bundles/org.eclipse.swt/Eclipse%20SWT/win32/org/eclipse/swt/widgets/Combo.java

I'm looking through that class now and will search for existing bugs.
Comment 8 Tony Homer CLA 2021-04-16 13:27:40 EDT
Maybe related? https://bugs.eclipse.org/bugs/show_bug.cgi?id=31305

Looking into Windows SWT Combo, there is definitely some special handling for adjusting the selection, for example:
https://github.com/eclipse/eclipse.platform.swt/blob/master/bundles/org.eclipse.swt/Eclipse%20SWT/win32/org/eclipse/swt/widgets/Combo.java#L2953

I'm not currently set up for development on Windows so I can't debug this behavior.