Bug 558369 - keybindings do not work on new workspace
Summary: keybindings do not work on new workspace
Status: CLOSED MOVED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.11   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 552208
  Show dependency tree
 
Reported: 2019-12-16 09:46 EST by Jonah Graham CLA
Modified: 2022-09-09 03:58 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonah Graham CLA 2019-12-16 09:46:51 EST
If you start a new workspace with Eclipse SDK, close the welcome screen and then press Ctrl-3 the Quick find does not work.

Workaround; 1. Click the (new*) Magnifying glass or in the textbox (Depending on the version) then Ctrl-3 works.

Note, I put in 4.11 as version as <=4.10 works and >=4.11 has this problem.



* <OT>Nice! I like this new UI element - that and the hamburger menu on views are the little improvements that make Eclipse continue to be nice</OT>
Comment 1 Lars Vogel CLA 2019-12-16 11:17:29 EST
I think there is a general problem with keybindings in a new workspace. Other shortcuts work for you?
Comment 2 Jonah Graham CLA 2019-12-16 11:49:03 EST
(In reply to Lars Vogel from comment #1)
> I think there is a general problem with keybindings in a new workspace.
> Other shortcuts work for you?

You are correct, other bindings, such as Ctrl-N and Alt-Shift-N do not work either. Same thing version wise, works with <= 4.10.
Comment 3 Jonah Graham CLA 2019-12-16 11:50:16 EST
The keyboard shortcuts work with the Welcome screen open, but stop working when you close the welcome screen, and then start working again when you press the magnifying glass.
Comment 4 Andrey Loskutov CLA 2019-12-16 11:53:00 EST
(In reply to Jonah Graham from comment #2)
> (In reply to Lars Vogel from comment #1)
> > I think there is a general problem with keybindings in a new workspace.
> > Other shortcuts work for you?
> 
> You are correct, other bindings, such as Ctrl-N and Alt-Shift-N do not work
> either. Same thing version wise, works with <= 4.10.

I believe this is also not necessarily related to the new workspace. I occasionally see that right after startup key bindings do not work.

Looks like initial focus / context is either not set or unset during UI startup, so that we need one extra click / focus change to make keybindings work.
Comment 5 Dani Megert CLA 2019-12-16 11:54:51 EST
No issue on Windows using

Eclipse SDK
Version: 2020-03 (4.15)
Build id: I20191215-1800
OS: Windows 10, v.10.0, x86_64 / win32
Java version: 14-ea
Comment 6 Wim Jongman CLA 2019-12-16 11:56:51 EST
(In reply to Jonah Graham from comment #3)
> The keyboard shortcuts work with the Welcome screen open, but stop working
> when you close the welcome screen, and then start working again when you
> press the magnifying glass.

I have a feeling that this might be caused by a broken binding context because the editor stack is empty after closing the welcome screen.

If you click on a view title instead of the search icon, does that also repair the key bindings?
Comment 7 Jonah Graham CLA 2019-12-16 12:03:23 EST
(In reply to Wim Jongman from comment #6)
> If you click on a view title instead of the search icon, does that also
> repair the key bindings?

Yes it does.



(In reply to Andrey Loskutov from comment #4)


Indeed I can reproduce like this too, no need for new workspace:

1) Start eclipse - no projects, no welcome screen open. At this point keys work
2) File -> New -> Untitled text file. Keys still work
3) Close the file. Keys stop working


(In reply to Dani Megert from comment #5)
> No issue on Windows using

I am running Linux (Xubuntu 18.04 and OpenJDK 8)
Comment 8 Mickael Istria CLA 2022-09-09 03:58:15 EDT
This was duplicated as GitHub issue https://github.com/eclipse-platform/eclipse.platform.ui/issues/324 . So let's close it here and move further discussions/fix to GitHub