Community
Participate
Working Groups
As seen in bug 558324, changes in ant code are green on Gerrit but fail in official build. If I see it right, there are no ant tests executed on Gerrit builds at all. We should enable that.
New Gerrit change created: https://git.eclipse.org/r/154543
So far I've managed that maven tries to start ant core tests, BUT I'm stopped by maven not finding test classes because of the special test bundle "layout". The bundle is supposed to produce two jars, and this makes maven unhappy. If I disable second jar generation, maven can find and start tests, but of course they require classes from the second library. https://ci.eclipse.org/platform/job/eclipse.platform-Gerrit/392/ Any hints how to teach maven where are the test classes if they are compiled NOT into target/classes? Our ant output (confuses maven test, can't find classes): https://ci.eclipse.org/platform/job/eclipse.platform-Gerrit/388/console 11:55:40 [INFO] --- tycho-compiler-plugin:1.5.1:compile (default-compile) @ org.eclipse.ant.tests.core --- 11:55:40 [INFO] Compiling 15 source files to /home/jenkins/agent/workspace/eclipse.platform-Gerrit/ant/org.eclipse.ant.tests.core/target/anttestscore.jar-classes 11:55:40 [INFO] Compiling 6 source files to /home/jenkins/agent/workspace/eclipse.platform-Gerrit/ant/org.eclipse.ant.tests.core/target/lib/antTestsSupport.jar-classes JDT debug output (maven test is found) https://ci.eclipse.org/jdt/job/eclipse.jdt.debug-Gerrit/1015/console 15:40:25 [INFO] --- tycho-compiler-plugin:1.5.1:compile (default-compile) @ org.eclipse.jdt.debug.tests --- 15:40:25 [INFO] Compiling 323 source files to /home/jenkins/agent/workspace/eclipse.jdt.debug-Gerrit/org.eclipse.jdt.debug.tests/target/classes Right now I'm playing with the idea of compiling everything in one library so maven is happy, but I think there should be a better solution.
So is this issue related to Java 11 move or it's a bigger one and happens even with Java 8?
(In reply to Alexander Kurtakov from comment #3) > So is this issue related to Java 11 move or it's a bigger one and happens > even with Java 8? Not Java 11 related, they seem never be enabled.
New Gerrit change created: https://git.eclipse.org/r/154812
New Gerrit change created: https://git.eclipse.org/r/154816
Gerrit change https://git.eclipse.org/r/154812 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=39ad3574906d010fc78ad4650f70f5bea909a123
Gerrit change https://git.eclipse.org/r/154816 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=b6ca97f22b461d0ce02664003c443e60441bc394
So ant.tests.ui happen to be easy one but core doesn't look the same. Still better some of the tests than none.
New Gerrit change created: https://git.eclipse.org/r/154838
(In reply to Alexander Kurtakov from comment #9) > So ant.tests.ui happen to be easy one but core doesn't look the same. Yes, the support classes (that built into extra jar) can't be found now. Bit at least you've managed to tell maven where the test classes are. > Still > better some of the tests than none. Sure, thanks!
New Gerrit change created: https://git.eclipse.org/r/154843
Gerrit change https://git.eclipse.org/r/154843 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=35263e28e1cdd8e7b2c80b1916976926a32e06f4
