Bug 558282 - Git master fails to compile
Summary: Git master fails to compile
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.0.36   Edit
Assignee: Alexander Kurtakov CLA
QA Contact: David Green CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2019-12-12 16:21 EST by Alexander Kurtakov CLA
Modified: 2020-01-08 13:46 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kurtakov CLA 2019-12-12 16:21:55 EST
Running mvn clean verify in top level dir leads to JVM crash:
Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)
j  org.eclipse.swt.internal.gtk.OS._XListProperties(JJ[I)J+0
j  org.eclipse.swt.internal.gtk.OS.XListProperties(JJ[I)J+11
j  org.eclipse.swt.program.Program.getDesktop(Lorg/eclipse/swt/widgets/Display;)I+74
j  org.eclipse.swt.program.Program.findProgram(Lorg/eclipse/swt/widgets/Display;Ljava/lang/String;)Lorg/eclipse/swt/program/Program;+46
j  org.eclipse.swt.program.Program.findProgram(Ljava/lang/String;)Lorg/eclipse/swt/program/Program;+4
j  org.eclipse.ui.internal.registry.EditorRegistry.isSystemExternalEditorAvailable(Ljava/lang/String;)Z+18
j  org.eclipse.ui.ide.IDE.getEditorDescriptor(Ljava/lang/String;Lorg/eclipse/ui/IEditorRegistry;Lorg/eclipse/ui/IEditorDescriptor;)Lorg/eclipse/ui/IEditorDescriptor;+34
j  org.eclipse.ui.ide.IDE.getEditorDescriptor(Lorg/eclipse/core/resources/IFile;Z)Lorg/eclipse/ui/IEditorDescriptor;+31
j  org.eclipse.ui.ide.IDE.getEditorDescriptor(Lorg/eclipse/core/resources/IFile;)Lorg/eclipse/ui/IEditorDescriptor;+2
j  org.eclipse.ui.ide.IDE.openEditor(Lorg/eclipse/ui/IWorkbenchPage;Lorg/eclipse/core/resources/IFile;)Lorg/eclipse/ui/IEditorPart;+13
j  org.eclipse.mylyn.internal.wikitext.ui.editor.syntax.EditFileHyperlink.open()V+21
Comment 1 Eclipse Genie CLA 2019-12-12 16:24:59 EST
New Gerrit change created: https://git.eclipse.org/r/154444
Comment 2 Leo Dos Santos CLA 2019-12-13 14:43:03 EST
Thanks Alexander. I've triggered the review job, so we can have a look at your patch.

Is this affecting Linux only, or is this tied to a particular JVM? I ran git master last week from my workspace without any issue, but I'm on Mac OS.
Comment 3 Alexander Kurtakov CLA 2019-12-13 14:46:37 EST
(In reply to Leo Dos Santos from comment #2)
> Thanks Alexander. I've triggered the review job, so we can have a look at
> your patch.
> 
> Is this affecting Linux only, or is this tied to a particular JVM? I ran git
> master last week from my workspace without any issue, but I'm on Mac OS.

The issue is a crash in SWT Gtk port when run on latest Gtk version. The ancient version mylyn docs was using couldn't have been ready for a version of Gtk not released back then. So short version Linux issue only and there have been many such we have fixed in SWT last few years.
Comment 5 Leo Dos Santos CLA 2019-12-19 17:31:24 EST
Thanks for this fix Alexander. Did we get all your changes in?
Comment 6 Alexander Kurtakov CLA 2019-12-19 19:34:40 EST
(In reply to Leo Dos Santos from comment #5)
> Thanks for this fix Alexander. Did we get all your changes in?

Not yet. https://git.eclipse.org/r/#/q/project:mylyn/org.eclipse.mylyn.docs+owner:%22Alexander+Kurtakov+%253Cakurtako%2540redhat.com%253E%22++status:open 
But this is pretty much everything for now. So if you want to cut new release I'll be happy to try it after vacation to see how much we can improve ```lang ``` blocks.
Comment 7 Leo Dos Santos CLA 2019-12-20 18:15:58 EST
Awesome. I think we got most of your patches in, which I just want to hear from the ePub maintainer for the last one. I will be off until the new year, but I'll try to check in before then to get the last review in.
Comment 8 Alexander Kurtakov CLA 2020-01-08 09:05:35 EST
All done from my side here. It would be nice to have a release which we can use in lsp4e now.
Comment 9 Leo Dos Santos CLA 2020-01-08 13:46:13 EST
Thanks Alexander! I'll be getting a new release out in the next couple of weeks.