558279 – WorkbenchWindow menu not consistent with e4 model

Bug 558279 - WorkbenchWindow menu not consistent with e4 model

Summary: WorkbenchWindow menu not consistent with e4 model

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.13
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.15 M1
Assignee:	Rolf Theunissen
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2019-12-12 15:18 EST by Rolf Theunissen
Modified:	2020-02-26 16:58 EST (History)
CC List:	2 users (show)

See Also:	374568 Gerrit Change Git Commit 558765 Gerrit Change Git Commit 560166

Attachments
Screenshot (145.53 KB, image/png) 2019-12-17 16:53 EST, Lars Vogel	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rolf Theunissen

2019-12-12 15:18:43 EST

The WorkbenchWindow main menu is not kept in sync with the E4 main menu. When changes are made to WorkbenchWindow, updateActionBars should be called, this does not sync the changes back to the model.

Also, the initial sync from the main menu to the model is inconsistent, breaking any attempt to update the model through the e4 model, See Bug 374568.

Comment 1 Eclipse Genie

2019-12-12 16:35:34 EST

New Gerrit change created: https://git.eclipse.org/r/154445

Comment 2 Lars Vogel

2019-12-17 16:53:45 EST

Created attachment 281260 [details]
Screenshot

If I hide the "Edit" menu with this change via the customize perspective dialog and open the dialog again I see additional entries. Without this patch this does not happen. 

Rolf, can you check?

Comment 3 Rolf Theunissen

2019-12-18 08:40:00 EST

(In reply to Lars Vogel from comment #2)
> Created attachment 281260 [details]
> Screenshot
> 
> If I hide the "Edit" menu with this change via the customize perspective
> dialog and open the dialog again I see additional entries. Without this
> patch this does not happen. 
> 
> Rolf, can you check?

The screenshot shows the Toolbar visibility tab, are you sure that you are looking at the correct tab?

Comment 4 Lars Vogel

2019-12-18 08:44:13 EST

(In reply to Rolf Theunissen from comment #3)

> The screenshot shows the Toolbar visibility tab, are you sure that you are
> looking at the correct tab?

LOL, most likely not. Sorry for the noise. I plan to have a customer IDE build with the change to test it in "real" life and will report if I still see this issue.

Comment 5 Eclipse Genie

2019-12-20 02:30:16 EST

Gerrit change https://git.eclipse.org/r/154445 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=32c650cf34170478908a1892d64a92aff635b63a

Comment 6 Eclipse Genie

2020-01-06 15:22:03 EST

New Gerrit change created: https://git.eclipse.org/r/155333

Comment 7 Rolf Theunissen

2020-01-06 15:27:01 EST

(In reply to Eclipse Genie from comment #6)
> New Gerrit change created: https://git.eclipse.org/r/155333

Need to partially revert this change, unwrapping SubContribution items can have undesired side-effects.

Comment 8 Eclipse Genie

2020-01-06 16:24:39 EST

Gerrit change https://git.eclipse.org/r/155333 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f03a14b1f602430de54d13902b8208aa28bc7a66

Comment 9 Rolf Theunissen

2020-01-06 16:26:53 EST

Any remaining issues should be solved as part of Bug 374568.