Bug 558257 - Added generics in platform.ui API break clients
Summary: Added generics in platform.ui API break clients
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.14   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.15 M1   Edit
Assignee: Paul Pazderski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 558259 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-12-12 07:11 EST by Paul Pazderski CLA
Modified: 2019-12-12 08:35 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Pazderski CLA 2019-12-12 07:11:34 EST 
https://git.eclipse.org/r/#/c/153766/ introduced errors in my local workspace and should fail the next build. Errors are in ExternalToolsBuildTab from org.eclipse.ui.externaltools and SelectResourcesDialog from org.eclipse.ui.editors for example.

Adding generics to API methods is kind of an API change* and to complex for a bugless change.

I recommend to revert the API changing parts of https://git.eclipse.org/r/#/c/153766/. The internal stuff should be fine.

*I'm still not sure it is an API change or just risky. Afaik API tools do not complain and https://wiki.eclipse.org/Evolving_Java-based_APIs_2#Turning_non-generic_types_and_methods_into_generic_ones is vague on this topic.
Comment 1 Paul Pazderski CLA 2019-12-12 07:13:26 EST 
PS: might be the same for https://git.eclipse.org/r/#/c/153751/
Comment 2 Eclipse Genie CLA 2019-12-12 07:22:06 EST 
New Gerrit change created: https://git.eclipse.org/r/154403
Comment 3 Paul Pazderski CLA 2019-12-12 07:31:39 EST 
*** Bug 558259 has been marked as a duplicate of this bug. ***