Bug 55822 - [CoolBar] CoolBarManager.setLayout is poor API
Summary: [CoolBar] CoolBarManager.setLayout is poor API
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.0 M9   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2004-03-23 22:36 EST by Nick Edgar CLA
Modified: 2004-05-09 01:32 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2004-03-23 22:36:25 EST 
build I20040323

CoolBarManager.setLayout has a couple of problems:
1. its Javadoc talks about internals
2. it takes an ArrayList of unspec'ed element type instead of IContributionItem[] 
3. it talks about order, but really it allows the whole set of items to be
replaced, not just reordered.

Should change to take an IContributionItem[] (and copy the array).
Comment 1 Nick Edgar CLA 2004-03-23 22:36:56 EST 
And rename it to setItems(IContributionItem[])
Comment 2 Nick Edgar CLA 2004-03-23 22:38:40 EST 
Should also revisit resetLayout.  Avoid the term layout to avoid confusion with
SWT layouts, e.g. resetItemOrder.
Comment 3 Nick Edgar CLA 2004-05-09 01:32:22 EDT 
Done.