Comment 1 DJ Houghton 2004-03-22 13:49:44 EST

Sorry, hit the wrong button.

build i0322

I loaded a patch file (resources from bug 36958) and had it in my workspace.
Then I did a Compare With HEAD. I clicked on the HistoryStore class and saw the
changes. Then I clicked on a field addition in the structure view and got the
following exception. 

I got a dialog saying that there was an exception but the resulting view looked ok.

!SESSION Mar 22, 2004 13:38:59.150 ---------------------------------------------
java.fullversion=J2RE 1.4.1 IBM J9 build 20031212 (JIT enabled)
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_US
Command-line arguments: -data \eclipse\target\prefs\plugins\ -showlocation
-console -vmargs -Xj9 -cp C:\eclipse\dev\i0322\eclipse\startup.jar
org.eclipse.core.launcher.Main
!ENTRY org.eclipse.core.runtime 4 2 Mar 22, 2004 13:38:59.150
!MESSAGE Problems occurred when invoking code from plug-in:
"org.eclipse.core.runtime".
!STACK 0
org.eclipse.jface.text.Assert$AssertionFailedException: Assertion failed: 
	at java.lang.Throwable.<init>(Throwable.java)
	at java.lang.Throwable.<init>(Throwable.java)
	at org.eclipse.jface.text.Assert$AssertionFailedException.<init>(Assert.java:54)
	at org.eclipse.jface.text.Assert.isTrue(Assert.java:175)
	at org.eclipse.jface.text.Assert.isTrue(Assert.java)
	at
org.eclipse.jface.text.projection.ProjectionMapping.toImageRegion(ProjectionMapping.java)
	at
org.eclipse.jface.text.projection.ProjectionMapping.toImageRegion(ProjectionMapping.java)
	at org.eclipse.jface.text.TextViewer.modelRange2WidgetRange(TextViewer.java)
	at org.eclipse.jface.text.TextViewer.addPresentation(TextViewer.java)
	at org.eclipse.jface.text.TextViewer.changeTextPresentation(TextViewer.java:4057)
	at
org.eclipse.jface.text.presentation.PresentationReconciler.applyTextRegionCollection(PresentationReconciler.java:559)
	at
org.eclipse.jface.text.presentation.PresentationReconciler.processDamage(PresentationReconciler.java:548)
	at
org.eclipse.jface.text.presentation.PresentationReconciler.access$5(PresentationReconciler.java:544)
	at
org.eclipse.jface.text.presentation.PresentationReconciler$InternalListener.textChanged(PresentationReconciler.java:218)
	at org.eclipse.jface.text.TextViewer.updateTextListeners(TextViewer.java:2233)
	at
org.eclipse.jface.text.TextViewer.invalidateTextPresentation(TextViewer.java:2885)
	at org.eclipse.jface.text.TextViewer.initializeWidgetContents(TextViewer.java:2932)
	at org.eclipse.jface.text.TextViewer.setVisibleDocument(TextViewer.java:2966)
	at org.eclipse.jface.text.TextViewer.setVisibleRegion(TextViewer.java:3056)
	at
org.eclipse.compare.contentmergeviewer.TextMergeViewer.setDocument(TextMergeViewer.java:1938)
	at
org.eclipse.compare.contentmergeviewer.TextMergeViewer.updateContent(TextMergeViewer.java:1636)
	at
org.eclipse.compare.contentmergeviewer.ContentMergeViewer.internalRefresh(ContentMergeViewer.java:661)
	at
org.eclipse.compare.contentmergeviewer.ContentMergeViewer.inputChanged(ContentMergeViewer.java:558)
	at org.eclipse.jface.viewers.ContentViewer.setInput(ContentViewer.java:238)
	at
org.eclipse.compare.CompareViewerSwitchingPane.setInput(CompareViewerSwitchingPane.java:302)
	at org.eclipse.compare.CompareEditorInput$11.run(CompareEditorInput.java:526)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java)
	at org.eclipse.compare.CompareEditorInput.feed1(CompareEditorInput.java:516)
	at org.eclipse.compare.CompareEditorInput.access$1(CompareEditorInput.java:515)
	at org.eclipse.compare.CompareEditorInput$6.open(CompareEditorInput.java:457)
	at
org.eclipse.compare.CompareViewerSwitchingPane$1.open(CompareViewerSwitchingPane.java:55)
	at org.eclipse.jface.viewers.StructuredViewer$2.run(StructuredViewer.java:406)
	at org.eclipse.core.internal.runtime.InternalPlatform.run(InternalPlatform.java)
	at org.eclipse.core.runtime.Platform.run(Platform.java)
	at org.eclipse.jface.viewers.StructuredViewer.fireOpen(StructuredViewer.java:404)
	at org.eclipse.jface.viewers.StructuredViewer.handleOpen(StructuredViewer.java:614)
	at
org.eclipse.jface.viewers.StructuredViewer$6.handleOpen(StructuredViewer.java:703)
	at org.eclipse.jface.util.OpenStrategy.fireOpenEvent(OpenStrategy.java:209)
	at org.eclipse.jface.util.OpenStrategy.access$2(OpenStrategy.java:204)
	at org.eclipse.jface.util.OpenStrategy$1.mouseSelectItem(OpenStrategy.java:344)
	at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1488)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1462)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:259)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:139)
	at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:90)
	at
org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:262)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:213)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:115)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:79)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:41)
	at java.lang.reflect.Method.invoke(Method.java:386)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:315)
	at org.eclipse.core.launcher.Main.run(Main.java:740)
	at org.eclipse.core.launcher.Main.main(Main.java:724)

Comment 2 DJ Houghton 2004-03-22 13:53:23 EST

Note that now whenever I click on something in the stucture view, nothing changes.

Closing the view and then re-opening it and clicking on the field gives me the
same behaviour. (error and then not updating the view)

Comment 3 John Arthorne 2004-03-23 10:40:53 EST

I don't think this is just a problem with compare editors.  I am getting the
quite frequently with Java editors in I20040322. It results in the entire editor
being unable to draw, and the editor must be closed and reopened. Here is a
sample stack trace:

org.eclipse.jface.text.Assert$AssertionFailedException: Assertion failed: 
	at java.lang.Throwable.<init>(Throwable.java)
	at java.lang.Throwable.<init>(Throwable.java)
	at org.eclipse.jface.text.Assert$AssertionFailedException.<init>(Assert.java:54)
	at org.eclipse.jface.text.Assert.isTrue(Assert.java:175)
	at org.eclipse.jface.text.Assert.isTrue(Assert.java)
	at
org.eclipse.jface.text.projection.ProjectionMapping.toImageRegion(ProjectionMapping.java)
	at
org.eclipse.jface.text.projection.ProjectionMapping.toImageRegion(ProjectionMapping.java)
	at org.eclipse.jface.text.TextViewer.modelRange2WidgetRange(TextViewer.java)
	at org.eclipse.jface.text.TextViewer.addPresentation(TextViewer.java)
	at org.eclipse.jface.text.TextViewer.changeTextPresentation(TextViewer.java)
	at
org.eclipse.jface.text.presentation.PresentationReconciler.applyTextRegionCollection(PresentationReconciler.java:559)
	at
org.eclipse.jface.text.presentation.PresentationReconciler.processDamage(PresentationReconciler.java:548)
	at
org.eclipse.jface.text.presentation.PresentationReconciler.access$5(PresentationReconciler.java:544)
	at
org.eclipse.jface.text.presentation.PresentationReconciler$InternalListener.textChanged(PresentationReconciler.java:218)
	at org.eclipse.jface.text.TextViewer.updateTextListeners(TextViewer.java:2233)
	at
org.eclipse.jface.text.TextViewer.invalidateTextPresentation(TextViewer.java:2885)
	at org.eclipse.jface.text.TextViewer.initializeWidgetContents(TextViewer.java:2932)
	at org.eclipse.jface.text.TextViewer.setVisibleDocument(TextViewer.java:2966)
	at org.eclipse.jface.text.TextViewer.setVisibleRegion(TextViewer.java:3056)
	at
org.eclipse.ui.texteditor.AbstractTextEditor.setHighlightRange(AbstractTextEditor.java:4051)
	at
org.eclipse.jdt.internal.ui.javaeditor.JavaEditor.adjustHighlightRange(JavaEditor.java:2496)
	at
org.eclipse.ui.texteditor.AbstractTextEditor.selectAndReveal(AbstractTextEditor.java:4132)
	at
org.eclipse.ui.texteditor.TextSelectionNavigationLocation.restoreLocation(TextSelectionNavigationLocation.java:254)
	at
org.eclipse.ui.internal.NavigationHistoryEntry.restoreLocation(NavigationHistoryEntry.java:65)
	at org.eclipse.ui.internal.NavigationHistory.gotoEntry(NavigationHistory.java:316)
	at org.eclipse.ui.internal.NavigationHistory.shiftEntry(NavigationHistory.java:360)
	at org.eclipse.ui.internal.NavigationHistory.backward(NavigationHistory.java:347)
	at
org.eclipse.ui.internal.NavigationHistoryAction.run(NavigationHistoryAction.java:187)
	at org.eclipse.jface.action.Action.runWithEvent(Action.java:881)
	at org.eclipse.ui.commands.ActionHandler.execute(ActionHandler.java:68)
	at org.eclipse.ui.internal.commands.Command.execute(Command.java:173)
	at
org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeCommand(WorkbenchKeyboard.java:460)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.press(WorkbenchKeyboard.java:834)
	at
org.eclipse.ui.internal.keys.WorkbenchKeyboard.processKeyEvent(WorkbenchKeyboard.java:875)
	at
org.eclipse.ui.internal.keys.WorkbenchKeyboard.filterKeySequenceBindings(WorkbenchKeyboard.java:519)
	at
org.eclipse.ui.internal.keys.WorkbenchKeyboard.access$2(WorkbenchKeyboard.java:485)
	at
org.eclipse.ui.internal.keys.WorkbenchKeyboard$1.handleEvent(WorkbenchKeyboard.java:258)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java)
	at org.eclipse.swt.widgets.Display.filterEvent(Display.java)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java)
	at org.eclipse.swt.widgets.Control.sendKeyEvent(Control.java:1720)
	at org.eclipse.swt.widgets.Control.sendKeyEvent(Control.java:1716)
	at org.eclipse.swt.widgets.Control.WM_SYSKEYDOWN(Control.java:4380)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java)
	at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method)
	at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1488)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1462)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:259)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:139)
	at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:90)
	at
org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:262)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:213)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:115)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:79)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:41)
	at java.lang.reflect.Method.invoke(Method.java:386)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:315)
	at org.eclipse.core.launcher.Main.run(Main.java:740)
	at org.eclipse.core.launcher.Main.main(Main.java:724)

Comment 4 Kai-Uwe Maetzel 2004-03-23 11:02:58 EST

Fixed in I200403230800.

Comment 5 Markus Keller 2004-03-26 05:00:26 EST

start verifying...

Comment 6 Markus Keller 2004-03-26 05:17:48 EST

verified in 200403260010: the scenario from comment 1 works now.