Community
Participate
Working Groups
We have many bugs in which the tree expand was slow before redrawn was not enabled. See Bug 522335 or Bug 543737. I suggest to change the default to redraw false, if the user does not specify a value.
New Gerrit change created: https://git.eclipse.org/r/153857
Noticed this while looking at Pauls change in https://git.eclipse.org/r/#/c/153853/. Any concerns here?
How shall we identify clients that would like to have redrawing while expanding a tree? I'm not sure which are those use cases. In many cases the user would like to have a faster result. But how this behaves, for example, in the project explorer? Some unwanted behavorial changes might be detected during a release iteration when this gets enabled early. I assume in most cases disabling the redraw while expand/collapse should be better.
(In reply to Karsten Thoms from comment #3) > How shall we identify clients that would like to have redrawing while > expanding a tree? I'm not sure which are those use cases. In many cases the > user would like to have a faster result. But how this behaves, for example, > in the project explorer? > Some unwanted behavorial changes might be detected during a release > iteration when this gets enabled early. I assume in most cases disabling the > redraw while expand/collapse should be better. Definitely not something for 4.14 but for 4.15. I hope nobody relies on slow drawing operation, if someone does we can reconsider.
(In reply to Karsten Thoms from comment #3) > How shall we identify clients that would like to have redrawing while > expanding a tree? I'm not sure which are those use cases. In many cases the > user would like to have a faster result. But how this behaves, for example, > in the project explorer? > Some unwanted behavorial changes might be detected during a release > iteration when this gets enabled early. I assume in most cases disabling the > redraw while expand/collapse should be better. It might also fix multiple issues, see for example Bug 442621 which will be fixed by a turned of return in collapse.
You asked for concerns, and this came to my mind ;) We should give it a try for early 4.15.
(In reply to Karsten Thoms from comment #6) > You asked for concerns, and this came to my mind ;) We should give it a try > for early 4.15. Indeed, I did. Thanks. :-)
Gerrit change https://git.eclipse.org/r/153857 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e8a6608fbfded4488c1a4014585aec7efb59c1f2