553663 – Icon selection dialog of the e4 application model editor resizes badly

Bug 553663 - Icon selection dialog of the e4 application model editor resizes badly

Summary: Icon selection dialog of the e4 application model editor resizes badly

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.14
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.15 M1
Assignee:	Platform-UI-Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2019-12-02 08:22 EST by Lars Vogel
Modified:	2019-12-16 04:06 EST (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Screenshot (44.75 KB, image/png) 2019-12-02 08:23 EST, Lars Vogel	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2019-12-02 08:22:48 EST

See screenshot, I suggest to enforce a minimum size for this dialog.

To test open e4 application model editor and create a part, use select icon dialog.

Comment 1 Lars Vogel

2019-12-02 08:23:01 EST

Created attachment 280834 [details]
Screenshot

Comment 2 Lars Vogel

2019-12-02 08:23:47 EST

Benedikt, something for you?

Comment 3 Eclipse Genie

2019-12-06 02:43:14 EST

New Gerrit change created: https://git.eclipse.org/r/153968

Comment 4 Benedikt Kuntz

2019-12-06 02:51:56 EST

I gave it a try, but there are some things to be considered:
- There is no minimum size for nearly all model editor dialogs (also for other Eclipse dialogs, e.g. MANIFEST.MF add dependency dialog)
- Some of the model editor dialogs inhibit resizing (without having an obvious reason for that)

In the patch set I decided to enable resizing and set a minimum size of the dialog shell for SaveDialogBoundsDialog which is the parent for nearly all model editor dialogs so the behaviour is consistent within the application editor. 
I guess this is more than this bug here covers, so maybe we could change it to apply for all the model editor dialogs. What do you think, Lars?

Comment 5 Eclipse Genie

2019-12-16 04:05:09 EST

Gerrit change https://git.eclipse.org/r/153968 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=88f44f2b33f2e755b79a7d07528a0481bf30f1a8

Comment 6 Alexander Fedorov

2019-12-16 04:06:19 EST

Thanks, Benedikt!

Submitted https://bugs.eclipse.org/bugs/show_bug.cgi?id=558352 for the future improvements.