Comment 1 Eclipse Genie 2019-11-26 23:27:15 EST

New Gerrit change created: https://git.eclipse.org/r/153457

Comment 2 Sarika Sinha 2019-11-27 03:01:00 EST

buildRemote.xml clearly says:
<javac target=“1.6” source=“1.6" destdir=“${destdir}” failonerror=“true” verbose=“false” debug=“on” includeAntRuntime=“yes”
                classpath=“${basedir}/bin”>
            <src path=“${basedir}/remote”/>
            <compilerarg value=“-Xlint”/>
        </javac>

Comment 3 Carsten Hammer 2019-11-27 03:04:53 EST

Right, sorry for that. Why did it not fail?

Comment 4 Sarika Sinha 2019-11-27 03:11:47 EST

(In reply to Carsten Hammer from comment #3)
> Right, sorry for that. Why did it not fail?

Unfortunately we build it only on demand. 
We need to add a way to catch this definitely. But till then we need to be careful.

Comment 5 Eclipse Genie 2019-11-27 03:13:26 EST

Gerrit change https://git.eclipse.org/r/153457 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=faa77f958bca6aa3ca2c281d508acf0710be9032

Comment 6 Sarika Sinha 2019-11-27 03:13:59 EST

Thanks Lakshmi.

Comment 7 Carsten Hammer 2019-11-27 05:49:51 EST

(In reply to Sarika Sinha from comment #2)
> buildRemote.xml clearly says:
> <javac target=“1.6” source=“1.6" destdir=“${destdir}” failonerror=“true”
> verbose=“false” debug=“on” includeAntRuntime=“yes”
>                 classpath=“${basedir}/bin”>
>             <src path=“${basedir}/remote”/>
>             <compilerarg value=“-Xlint”/>
>         </javac>

My gerrit was based on the complience to 1.8 set in
 
org.eclipse.jdt.core.compiler.compliance=1.8

https://git.eclipse.org/c/platform/eclipse.platform.git/tree/ant/org.eclipse.ant.launching/.settings/org.eclipse.jdt.core.prefs?id=faa77f958bca6aa3ca2c281d508acf0710be9032

Maybe this is wrong?

Comment 8 Sarika Sinha 2019-11-27 05:55:14 EST

(In reply to Carsten Hammer from comment #7)
> (In reply to Sarika Sinha from comment #2)
> > buildRemote.xml clearly says:
> > <javac target=“1.6” source=“1.6" destdir=“${destdir}” failonerror=“true”
> > verbose=“false” debug=“on” includeAntRuntime=“yes”
> >                 classpath=“${basedir}/bin”>
> >             <src path=“${basedir}/remote”/>
> >             <compilerarg value=“-Xlint”/>
> >         </javac>
> 
> My gerrit was based on the complience to 1.8 set in
>  
> org.eclipse.jdt.core.compiler.compliance=1.8
> 
> https://git.eclipse.org/c/platform/eclipse.platform.git/tree/ant/org.eclipse.
> ant.launching/.settings/org.eclipse.jdt.core.
> prefs?id=faa77f958bca6aa3ca2c281d508acf0710be9032
> 
> Maybe this is wrong?

This is correct. But to be able to allow people to run Ant scripts in headless mode it is required that remote.jar is built with this.

Comment 9 Sarika Sinha 2019-12-06 02:07:44 EST

Eclipse SDK

Version: 2019-12 (4.14)
Build id: I20191204-1800