Bug 553227 - Custom partstack renderer's lazyLoader not reinitialized
Summary: Custom partstack renderer's lazyLoader not reinitialized
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.14   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-19 11:02 EST by Tobias Weißer CLA
Modified: 2020-09-10 14:24 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Weißer CLA 2019-11-19 11:02:47 EST 
I've a custom partstack renderer in place, which is basically working as intended.

However, the lazyLoader EventHandler in the LazyStackRenderer is unsubscribed from the eventBroker as soon as the IEclipseContext is disposed, but not the renderer itself.

If a new partstack is created afterwards, the PartRenderingEngine just uses the previously created custom renderer, but is not subscribing the lazyLoader EventHandler to the eventBroker again.

This results in newly activated tabs not being shown anymore and some other strange behavior.

ps: I only need this custom renderer because the NoDetach tag is completely ignored by the StackRenderer#populateTabMenu method. I think this should be checked like it is done for the NoClose tag already!

Greetings
Tobias