Bug 5528 - Search result view is slow to update
Summary: Search result view is slow to update
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Search (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-11-05 09:11 EST by Philipe Mulet CLA
Modified: 2001-11-05 13:00 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2001-11-05 09:11:22 EST
Build 207 (20011101)

In a self-hosting workspace, when searching for declarations of a Java method 
named 'close' through the Java search page, I obtained 296 matches.

Then I sorted them by path, and selected all matches outside 
org.eclipse.jdt.core, and remove these entries.

The view took 17 seconds to update (without any progress) the list of 28 items 
remaining !!! Seemed like it was iteratively discarding them one by one.
Comment 1 Erich Gamma CLA 2001-11-05 09:24:56 EST
17 seconds is too long, pls investigate where the time is going.
Comment 2 Dani Megert CLA 2001-11-05 11:09:08 EST
We might not have exactly the same setup but it is not that slow here. When I do 
the search I get 177 matches. If I select all except one and then remove the 
entires it takes about 4 seconds.

When I delete all but one result from a search with 260 matches it also takes 
about 4 seconds.

All markers are deleted in one call and I get one resource delta. This contains 
the removed markers which I process.

The update could be improved by
- disabling/enabling redraw during the updates
- coupling the remove actions directly to the search manager but this will not 
work if a bunch of search markers is removed somewhere else.
Comment 3 Philipe Mulet CLA 2001-11-05 12:43:01 EST
I reproduce it each time, either on 206 or 207. It is always above 15 seconds.
Comment 4 Dani Megert CLA 2001-11-05 13:00:05 EST
Fixed in builds > 208 (20011105)
Also added busy cursor.