Bug 552728 - [Dark Theme] Search shows white artifacts
Summary: [Dark Theme] Search shows white artifacts
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.14   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2019-11-06 04:58 EST by Lars Vogel CLA
Modified: 2023-05-15 12:11 EDT (History)
7 users (show)

See Also:


Attachments
Screenshot (57.20 KB, image/png)
2019-11-13 08:18 EST, Lars Vogel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-11-06 04:58:52 EST

    
Comment 1 Lars Vogel CLA 2019-11-13 08:18:42 EST
Created attachment 280624 [details]
Screenshot
Comment 2 Lars Vogel CLA 2019-11-13 08:19:19 EST
If I switch to another tab and tab back, it is styled.
Comment 3 Lars Vogel CLA 2019-11-13 08:20:18 EST
Roland, any idea why this happens?
Comment 4 Roland Grunberg CLA 2019-11-13 10:33:51 EST
Version: 2019-12 (4.14)
Build id: I20191112-1800

I can also reproduce with a plain Eclipse SDK, but I don't think this is a JDT bug.

(With dark theme enabled)
1) Search -> Search... . You can actually select 'Search...', 'File...' or even 'Java...'
2) Select any other tab (that isn't the one currently selected) and notice that the area at the bottom becomes as in the screenshot

If you resize the dialog, the colour is corrected. Can you confirm this ?
Comment 5 Lars Vogel CLA 2019-11-13 10:44:04 EST
Yes, resize fixes it. Maybe we must call layout or requestLayout at a tab switch?
Comment 6 Roland Grunberg CLA 2019-11-18 15:52:30 EST
That looks to be the case. The issue is reproducible on Windows 10 as well.
Comment 7 Lars Vogel CLA 2020-05-18 07:51:28 EDT
Looks like I never find the time to investigate this one. Help wanted
Comment 8 Pierre-Yves Bigourdan CLA 2020-08-15 10:17:32 EDT
Interestingly, this issue does not happen with the DevStyle themes.
Comment 9 John Moule CLA 2022-05-23 18:27:22 EDT
Hi, I'd like to contribute a patch to fix this in the SearchDialog (in repo eclipse.platform.text.git)

I'm having a little bit of trouble setting up git. Should I be using this guide [1] or something else?

[1]: https://wiki.eclipse.org/Platform/How_to_Contribute#.5B3.2.5D_Use_ssh_for_clone.2Fpush
Comment 10 John Moule CLA 2022-06-06 13:16:32 EDT
Hi Lars,

I've pushed a change which fixes this problem.

https://github.com/eclipse-platform/eclipse.platform.text/pull/40#issue-1262116382


First time pushing to github from Eclipse so all feedback gratefully received if there are improvements to be made in my process.

The controls to add reviewers are greyed out so I haven't added any.

Is there a way to see the github progress in this bugzilla?

Cheers John
Comment 11 John Moule CLA 2023-05-15 12:11:46 EDT
Discussion continued on GH:

https://github.com/eclipse-platform/eclipse.platform.text/pull/40

I've added file Bug552728.zip which is an Eclipse Plug-in Project. It contains a compact test reproduction case to demonstrate the bug

https://github.com/eclipse-platform/eclipse.platform.text/pull/40#discussion_r1119094440

Unfortunately, I haven't been able to solve where the white artifact comes from using this test case. I've stepped through Composite.layout() and GridLayout.layout(Composite, boolean) and don't see anything obviously suspicious.

Any tips/insights where I should look gratefully received.