Description Michael Keppler 2019-11-05 15:44:08 EST

Created attachment 280517 [details]
profiler screenshot

When opening a context menu on a selection containing 200 projects, it takes about 1 second of wallclock time on my machine until the menu is shown.

According to Yourkit, quite some of that time is needed for calculating whether there are property pages available. That calculation is always done for all elements of the selection, even if the union of common property pages is already empty (we should return early, if the result set becomes empty during the iteration).

Afterwards the result set of property page contributors is checked for whether these property pages are actually applicable for multi selection. In most cases, property pages are _not_ applicable for multi selection. Therefore if that check would be done while still iterating the selection, we would have an empty result much earlier, leading to an early exit again.

If I apply those 2 changes, in all my local tests using a platform.ui runtime workspace the property page calculation finishes already during the first iteration of the loop over the multi selection (since all property pages are not applicable for multi selection), thereby increasing the performance drastically.