Bug 552617 - [Cocoa] Test_org_eclipse_swt_custom_StyledText.test_setStyleRanges_render JUnit failure seen on MAC
Summary: [Cocoa] Test_org_eclipse_swt_custom_StyledText.test_setStyleRanges_render JUn...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.14   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.14 M3   Edit
Assignee: Lakshmi P Shanmugam CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-01 05:47 EDT by Niraj Modi CLA
Modified: 2019-11-20 05:14 EST (History)
3 users (show)

See Also:

Attachments
Screenshot of failing case (488 bytes, image/png)
2019-11-14 03:47 EST, Lakshmi P Shanmugam CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Niraj Modi CLA 2019-11-01 05:47:12 EDT 
Raising bug to track JUnit Test failure on MAC:
"Test_org_eclipse_swt_custom_StyledText.test_setStyleRanges_render"

Link to the JUnit test result for MAC:
https://download.eclipse.org/eclipse/downloads/drops4/I20191024-1800/testresults/html/org.eclipse.swt.tests_ep414I-unit-mac64-java8_macosx.cocoa.x86_64_8.0.html
Comment 1 Lakshmi P Shanmugam CLA 2019-11-14 03:47:45 EST 
Created attachment 280637 [details]
Screenshot of failing case

The test was always disabled on Mac due to Bug 536588.
It was enabled recently by https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=1ef69a696e82963c1b935ca9bcea9931ee143448.

Bug 536588 is fixed but the test fails now due to a different reason. 
The Image is being captured correctly, but there is some white background still visible (see screenshot) causing the last assertFalse(hasPixel(text, text.getBackground())) to fail.

I can either disable the test or just not run the failing assert on Mac.
Comment 2 Mickael Istria CLA 2019-11-14 04:04:11 EST 
(In reply to Lakshmi Shanmugam from comment #1)
> I can either disable the test or just not run the failing assert on Mac.

Either would be ok for me. Please just make sure you reference to that bug in the comment so we know what to do if we want to re-enable it later (ie better compute screenshot area).
Comment 3 Eclipse Genie CLA 2019-11-15 04:20:07 EST 
New Gerrit change created: https://git.eclipse.org/r/152716
Comment 4 Lakshmi P Shanmugam CLA 2019-11-15 04:23:54 EST 
(In reply to Mickael Istria from comment #2)
> (In reply to Lakshmi Shanmugam from comment #1)
> > I can either disable the test or just not run the failing assert on Mac.
> 
> Either would be ok for me. Please just make sure you reference to that bug
> in the comment so we know what to do if we want to re-enable it later (ie
> better compute screenshot area).

Opened Bug 553090 to track the problem.
Comment 6 Lakshmi P Shanmugam CLA 2019-11-20 05:14:37 EST 
Verified I20191119-2200