Bug 552545 - Change default for "Always show Welcome at start up" Welcome page
Summary: Change default for "Always show Welcome at start up" Welcome page
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 4.14   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.15 RC1   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted, usability
Depends on:
Blocks: 553537
  Show dependency tree
 
Reported: 2019-10-30 05:01 EDT by Lars Vogel CLA
Modified: 2020-02-17 07:24 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-10-30 05:01:28 EDT 
Since I started to use Oomph I see the Welcome screen on very startup up and noticed that "Always show Welcome at start up" is set to true.

I was not even aware of this setting, as I have not yet seen it in the SDK. 

Where does that come from? I suggest to set this by default to false. The Welcome page is not that useful on startup as it is more or less static and after installation of new components it is anyways displayed again.
Comment 1 Rolf Theunissen CLA 2019-11-21 06:33:49 EST 
That the welcome screen always pops up is not related to using Oomph. In fact, it should always pop-up as implemented by Bug 241885.

See classes AlwaysWelcomeCheckbox and WorkbenchWindowAdvisor#openIntro
Comment 2 Dani Megert CLA 2019-11-21 08:21:01 EST 
(In reply to Rolf Theunissen from comment #1)
> That the welcome screen always pops up is not related to using Oomph. In
> fact, it should always pop-up as implemented by Bug 241885.
> 
> See classes AlwaysWelcomeCheckbox and WorkbenchWindowAdvisor#openIntro
The option is there but it was never set to true for the SDK, which is good. So, someone outside the SDK must set it to true.

This bug either needs to be moved or closed.
Comment 3 Rolf Theunissen CLA 2019-11-21 09:04:14 EST 
IWorkbenchPreferenceConstants.java:
	/**
	 * A named preference indicating whether the workbench should show the
	 * introduction component (if available) on startup.
	 *
	 * <p>
	 * The default value for this preference is: <code>true</code> (show intro)
	 * </p>
	 *
	 * @see org.eclipse.ui.application.WorkbenchWindowAdvisor#openIntro()
	 * @since 3.0
	 */
	String SHOW_INTRO = "showIntro"; //$NON-NLS-1$

AlwaysWelcomeCheckbox.java:
	public boolean getAlwaysShowIntroPref()
	{
		// If uninitialized, we will default to true (box will be checked)
		if (!ReopenUtil.isReopenPreferenceInitialized()) {
			setAlwaysShowIntroPref(true);
		}
		return ReopenUtil.isReopenPreference();
	}

To me it seems that the default is to show the welcome screen. Unless the SDK disables the showIntro, i.e. by setting the org.eclipse.ui/showIntro=false preference. However, i did not find that property in the plugin_customization.ini files.
Comment 4 Dani Megert CLA 2019-11-21 09:15:53 EST 
(In reply to Rolf Theunissen from comment #3)
> IWorkbenchPreferenceConstants.java:
> 	/**
> 	 * A named preference indicating whether the workbench should show the
> 	 * introduction component (if available) on startup.
> 	 *
> 	 * <p>
> 	 * The default value for this preference is: <code>true</code> (show intro)
> 	 * </p>
> 	 *
> 	 * @see org.eclipse.ui.application.WorkbenchWindowAdvisor#openIntro()
> 	 * @since 3.0
> 	 */
> 	String SHOW_INTRO = "showIntro"; //$NON-NLS-1$
> 
> AlwaysWelcomeCheckbox.java:
> 	public boolean getAlwaysShowIntroPref()
> 	{
> 		// If uninitialized, we will default to true (box will be checked)
> 		if (!ReopenUtil.isReopenPreferenceInitialized()) {
> 			setAlwaysShowIntroPref(true);
> 		}
> 		return ReopenUtil.isReopenPreference();
> 	}
> 
> To me it seems that the default is to show the welcome screen. Unless the
> SDK disables the showIntro, i.e. by setting the
> org.eclipse.ui/showIntro=false preference. However, i did not find that
> property in the plugin_customization.ini files.
At any rate, showing the Welcome page again on restart after the user closed it is just plain wrong and AFAIK we (SDK) never did that. Note however, that once the user installs something which has Help content, the Welcome page is shown again.
Comment 5 Rolf Theunissen CLA 2019-11-21 11:15:30 EST 
I do think that SDK is responsible for the code that makes the WelcomePage always pop-up. But probably due to some clever configuration this problem does not show in the product as delivered by the platform project.

In org.eclipse.ui.intro.universal/introContent.xml:

<group id="extra-group5" filteredFrom="swt">
	<anchor id="anchor" />
	<contentProvider id="welcome-restart-check" pluginId="org.eclipse.ui.intro"
		class="org.eclipse.ui.intro.contentproviders.AlwaysWelcomeCheckbox" />
</group>

But probably the SDK product is configured to not use the default introContent page.
Comment 6 Rolf Theunissen CLA 2019-11-21 11:25:51 EST 
The behavior of the Welcome Screen is triggered with the following preferences:

# Use quadrant root page with quicklinks
org.eclipse.ui.intro/INTRO_START_PAGE = qroot
org.eclipse.ui.intro/INTRO_HOME_PAGE = qroot
Comment 7 Lars Vogel CLA 2019-11-27 07:55:16 EST 
Thanks, Rolf for the analysis. Lets fix this evil guy in 4.15 M1.
Comment 8 Eclipse Genie CLA 2020-02-17 06:37:10 EST 
New Gerrit change created: https://git.eclipse.org/r/157814
Comment 9 Lars Vogel CLA 2020-02-17 06:37:51 EST 
(In reply to Eclipse Genie from comment #8)
> New Gerrit change created: https://git.eclipse.org/r/157814

Rolf, can you review / test the change?
Comment 11 Eclipse Genie CLA 2020-02-17 07:23:39 EST 
New Gerrit change created: https://git.eclipse.org/r/157822