Bug 552372 - Eclipse fails to start with 'org.eclipse.datatools.enablement.sybase.feature' installed
Summary: Eclipse fails to start with 'org.eclipse.datatools.enablement.sybase.feature'...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.14   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: 4.14 M3   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks: 552175
  Show dependency tree
 
Reported: 2019-10-24 05:57 EDT by Martin Coufal CLA
Modified: 2019-10-25 04:03 EDT (History)
5 users (show)

See Also:

Attachments
workspace log (66.06 KB, text/x-log)
2019-10-24 05:57 EDT, Martin Coufal CLA 		no flags Details
reproducing script (desctructive!) (914 bytes, application/x-shellscript)
2019-10-24 05:58 EDT, Martin Coufal CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Coufal CLA 2019-10-24 05:57:31 EDT 
Created attachment 280403 [details]
workspace log

Eclipse fails to start with: BundleException: Exception in org.eclipse.core.resources.ResourcesPlugin.start() of bundle org.eclipse.core.resources. For more details, see workspace log.

How to reproduce:
1. install 'org.eclipse.datatools.enablement.sybase.feature.feature.group'
2. run eclipse without parameter `-data`

Attaching reproduction script...

My configuration:
RHEL-7.8-20191009.6
Java 1.8.0_232-ea
Eclipse Platform I20191020-1800
Data Tools Platform Enablement for Sybase 1.14.101.201811012051
Comment 1 Martin Coufal CLA 2019-10-24 05:58:23 EDT 
Created attachment 280404 [details]
reproducing script (desctructive!)
Comment 2 Andrey Loskutov CLA 2019-10-24 06:59:46 EDT 
I fear bug 552175 must be reverted.
Comment 3 Eclipse Genie CLA 2019-10-24 07:48:39 EDT 
New Gerrit change created: https://git.eclipse.org/r/151516
Comment 4 Andrey Loskutov CLA 2019-10-24 07:59:48 EDT 
(In reply to Eclipse Genie from comment #3)
> New Gerrit change created: https://git.eclipse.org/r/151516

Karsten, this removes the "eager activation" and the main part of the bug 	552175. I've wrote in bug 552175 comment 26 / commit message why the chosen approach is dangerous.

In bug 552175 we should check *if* there is a way to do this JXPath optimization *without* loading classes / activating bundles.

Current state with eager bundle activation is unfortunately not acceptable, my bad I haven't seen this earlier.
Comment 6 Andrey Loskutov CLA 2019-10-25 03:12:53 EDT 
(In reply to Eclipse Genie from comment #5)
> Gerrit change https://git.eclipse.org/r/151516 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=85cca0f79d0fa796995271e4b09047f691b8411f

This fix should be now in the build https://download.eclipse.org/eclipse/downloads/drops4/I20191024-1800/

@Martin: please verify that this fixes your issue.
Comment 7 Martin Coufal CLA 2019-10-25 03:47:08 EDT 
(In reply to Andrey Loskutov from comment #6)
> (In reply to Eclipse Genie from comment #5)
> > Gerrit change https://git.eclipse.org/r/151516 was merged to [master].
> > Commit:
> > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> > ?id=85cca0f79d0fa796995271e4b09047f691b8411f
> 
> This fix should be now in the build
> https://download.eclipse.org/eclipse/downloads/drops4/I20191024-1800/
> 
> @Martin: please verify that this fixes your issue.

Thanks Andrey, the issue is fixed in I20191024-1800.
Comment 8 Andrey Loskutov CLA 2019-10-25 04:02:57 EDT 
Thanks Martin for reporting & verification!