Bug 552371 - [code mining] Some mining text displayed on the same line as code
Summary: [code mining] Some mining text displayed on the same line as code
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.14   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.14 M3   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks: 530878
  Show dependency tree
 
Reported: 2019-10-24 05:09 EDT by Martin Coufal CLA
Modified: 2019-11-21 03:51 EST (History)
6 users (show)

See Also:


Attachments
screenshot (42.73 KB, image/png)
2019-10-24 05:09 EDT, Martin Coufal CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Coufal CLA 2019-10-24 05:09:34 EDT
Created attachment 280402 [details]
screenshot

Some of the mining texts are displayed on the same line as the code - see screenshot for details.

How to reproduce:
1. run Eclipse
2. have Eclipse Java Development Tools installed
3. enable code minings in Preferences -> Java -> Editor -> Code Minings -> Enable code minings
4. create new Java project, create classes:

-> Main:
"
package testCodeMinings;

public class Main {

	public static void main(String[] args) {
		TestCodeMinings.testCodeMinings();
	}

}
"

-> TestCodeMinings:
"
package testCodeMinings;

public class TestCodeMinings {
	public static void testCodeMinings() {
		System.out.println("This is test method that does NOTHING!");
	}
}
"

5. see TestCodeMinings class, code mining text is on the same line as code and totally unreadable

My configuration:
RHEL-8.1.0-20191015.0 + x11 (but same applies to wayland)
Java 1.8
Eclipse Platform I20191023-1810
Eclipse Java Development Tools 3.18.200.v20191009-1800
Comment 1 Jeff Johnston CLA 2019-10-24 13:31:05 EDT
I am able to reproduce this with the I-build mentioned on my RHEL 7.7 machine so it is not RHEL 8 specific.
Comment 2 Jeff Johnston CLA 2019-10-25 10:22:12 EDT
Problem was introduced between the I20191014 (works) and I20191018 (doesn't) I-builds.
Comment 3 Andrey Loskutov CLA 2019-10-25 10:40:08 EDT
(In reply to Jeff Johnston from comment #2)
> Problem was introduced between the I20191014 (works) and I20191018 (doesn't)
> I-builds.

Related to bug 530878 / patch https://git.eclipse.org/r/#/c/120156/?
Comment 4 Mickael Istria CLA 2019-10-25 10:45:03 EDT
(In reply to Andrey Loskutov from comment #3)
> Related to bug 530878 / patch https://git.eclipse.org/r/#/c/120156/?

Very likely.
Comment 5 Andrey Loskutov CLA 2019-10-25 10:46:29 EDT
Mickael, please check if we should revert the patch for bug 530878 or if we can fix that.
Comment 6 Andrey Loskutov CLA 2019-10-25 10:47:26 EDT
I can confirm that reverting commit 1ef69a696e82963c1b935ca9bcea9931ee143448 fixes the problem.
Comment 7 Mickael Istria CLA 2019-10-30 13:53:55 EDT
Verified in  I20191030-0010 and fixed by latest patch in bug 530878.
Comment 8 Niraj Modi CLA 2019-11-21 03:51:32 EST
(In reply to Mickael Istria from comment #7)
> Verified in  I20191030-0010 and fixed by latest patch in bug 530878.

Marking verified.