Community
Participate
Working Groups
I have recreated this using Eclipse 4.6.3 and 4.12. The recreate steps are as follows: 1) I started Eclipse 4.6.3 and created a new project with two text files in it. text1.txt with contents of: line 1 line 2 line 3 text2.txt with contents of: line 1 line 1a line 2 line 3 line 4 2) close both files 3) select both files and Compare with > Each other 4) Press the button to copy the current change from right to left 5) notice the asterisk in the compare editor tab indicating that text1.txt is now dirty, because "line 1a" has been added to text1.txt 6) Press the Swap Left and Right view button 7) notice the changes that were made for text1.txt are lost, the compare editor is no longer marked as dirty, and there was no warning prompting whether to save or informing me that my changes would be lost.
Perhaps related: https://github.com/eclipse/xtext-eclipse/issues/1010 Seems to have to do with corrupted internal state after the swap; in the xtext case Christian mentioned stale listeners.
Did some initial investigation, yet to reach a fix. Will continue on this in next release.
Moving out of 4.15
Yet to reach a fix for this, one important point to note the steps mentioned in comment 0 are working fine for .java files and are only breaking for .txt file Will continue my investigation for what best can be done here. I am open for inputs from anybody expert in Compare module. Thanks!
This has been moved many times now. Please fix for 4.16 M3.
Too late now. MOve to 4.17 M1
IMO, not an issue in Compare module and may be related to "Text editor" since "Java editor" works fine for the very same set of steps. Had a discussion on the bug scenario with Kalyan for his evaluation of the problem from Platform UI side.
Kalyan and I had couple of combined investigations on this issue, but no success so far. Any help from the community(specifically from the Compare side) is appreciated here. Thanks!!
Remove target milestone.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/173548
(In reply to Eclipse Genie from comment #10) > New Gerrit change created: > https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/173548 Attempted a fix which prompts with a Save dialog to avoid possible data loss with .txt files with steps mentioned in comment 0
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/173548 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=de4586082ceb8daa5475f043babc6bb31b602a02
Checked the fix in below recent 4.19 IBuild: https://download.eclipse.org/eclipse/downloads/drops4/I20201208-2310/ Resolving now.
Reopening for back-port to 4.15+, 4.11+, 4.8+, 4.6.3+ maintenance branches.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/173134
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/173134 was merged to [R4_15_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=531212b9a4311fe670339cd05a0ea64f1c88eefa
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/173643
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/173643 was merged to [R4_11_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=80499648edf603efe314637a36c76868ee7858c0
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/173644
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/173644 was merged to [R4_8_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=9de1abf789c2b02156ad3e3900edcad6d8f09b0c
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/173645
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/173645 was merged to [R4_6_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=d28c8d121012ad4ff872028c44c8e6bd3b027238
(In reply to Niraj Modi from comment #14) > Reopening for back-port to 4.15+, 4.11+, 4.8+, 4.6.3+ maintenance branches. Done with the back-porting, marking resolve.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/173806
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/173806 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=5401637a61a6e99f5c6f2c4c40a17919998e56c3
