552329 – FieldEditor should not use preference store field directly

Bug 552329 - FieldEditor should not use preference store field directly

Summary: FieldEditor should not use preference store field directly

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.13
Hardware:	All All

Importance:	P1 blocker (vote)
Target Milestone:	4.14 M3
Assignee:	Christoph Laeubrich
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	552325
	Show dependency tree

Reported:	2019-10-22 11:58 EDT by Christoph Laeubrich
Modified:	2019-10-23 05:33 EDT (History)
CC List:	1 user (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Christoph Laeubrich

2019-10-22 11:58:44 EDT

FieldEditor directly accesses the Field 'preferenceStore' but getPreferenceStore() is not final, so it is possible that a class overrides getPreferenceStore() leading to unexpected behavior if this is not implemented in consunction with "setPrefrenceStore"

Comment 1 Eclipse Genie

2019-10-22 12:06:39 EDT

New Gerrit change created: https://git.eclipse.org/r/151443

Comment 2 Eclipse Genie

2019-10-22 17:55:41 EDT

Gerrit change https://git.eclipse.org/r/151443 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=11273632c9367c2687fde654bcccf171c9af783c

Comment 3 Andrey Loskutov

2019-10-23 05:33:46 EDT

Thanks Christoph! Verified with I20191022-1800.