552144 – Filtering in Quick switch editor (Ctrl+E) not working correctly

Bug 552144 - Filtering in Quick switch editor (Ctrl+E) not working correctly

Summary: Filtering in Quick switch editor (Ctrl+E) not working correctly

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.14
Hardware:	PC Windows 10

Importance:	P3 normal (vote)
Target Milestone:	4.15 M1
Assignee:	Patrik Suzzi
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (1):	519302 (view as bug list)
Depends on:
Blocks:	553792
	Show dependency tree

Reported:	2019-10-16 08:58 EDT by Noopur Gupta
Modified:	2020-02-13 04:44 EST (History)
CC List:	5 users (show)

See Also:	548481 Gerrit Change Git Commit

Attachments
Demo of the Ctrl+E dialog with adjusted behaviour (937.94 KB, image/gif) 2019-12-05 00:44 EST, Patrik Suzzi	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Noopur Gupta

2019-10-16 08:58:08 EDT

I20191011-1800

- Keep a class JavaElement.java open in the workspace.

1) Invoke Ctrl+E (quick switch editor), type "JE" i.e. camel case for JavaElement.java. 
=> No results found.

2) Another issue is that typing "J" highlights the "j" in ".java" rather than "J" in any type starting with "J".

Comment 1 Rolf Theunissen

2019-10-16 11:25:14 EDT

This filtering does work for the window used for the chevron in the PartStack. The two implementation should be aligned anyhow, see Bug 548481.

Comment 2 Patrik Suzzi

2019-11-26 02:24:15 EST

I'll take it and try to fix before 2019-12 M3 

Cause: bad pattern match

We should check the org.eclipse.ui.dialogs.StyledStringHighlighter's methods:
 - StyledStringHighlighter.escapeSpecialCharacters(String)
 - StyledStringHighlighter.highlight(String, String, StyledString, Styler)

Debuggable in WorkbookEditorsHandlern line 150 calling StyledStringHighlighter#highlight (line 23 and 84)

Comment 3 Patrik Suzzi

2019-12-05 00:44:56 EST

Created attachment 280872 [details]
Demo of the Ctrl+E dialog with adjusted behaviour

The change will follow shortly, as soon as I complete testing.

Comment 4 Eclipse Genie

2019-12-05 01:46:24 EST

New Gerrit change created: https://git.eclipse.org/r/153876

Comment 5 Eclipse Genie

2019-12-14 11:00:53 EST

Gerrit change https://git.eclipse.org/r/153876 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=909e1b1e334a8c9d43d16fc1754b355b931e0155

Comment 6 Patrik Suzzi

2019-12-18 00:09:10 EST

*** Bug 519302 has been marked as a duplicate of this bug. ***

Comment 7 Mauro Molinari

2020-02-13 04:44:18 EST

Does this fix address bug #543191 or bug #292884?