Bug 552125 - ShowInMenu does not provide command parameters from menu contributions
Summary: ShowInMenu does not provide command parameters from menu contributions
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.14   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.14 M3   Edit
Assignee: Karsten Thoms CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 537617
  Show dependency tree
 
Reported: 2019-10-15 14:06 EDT by Karsten Thoms CLA
Modified: 2019-10-18 18:07 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karsten Thoms CLA 2019-10-15 14:06:30 EDT 
In change https://git.eclipse.org/r/c/150213/ a menu contribution is provided to the 'Show In' menu. For command 'org.eclipse.ui.views.showView' the command parameter 'org.eclipse.ui.views.showView.viewId' is provided with the target view as parameter value.

In org.eclipse.ui.internal.ShowInMenu.fillMenu(IMenuManager) CommandContributionItemParameter's are created, but the MenuItem's parameters are not considered. As a result, the created ParameterizedCommand does not have any 'parameterizations'.

As a result, the invoked ShowViewHandler gets an event without parameters and opens the Show View dialog. The ExecutionEvent needs to get the menu command parameters.
Comment 1 Eclipse Genie CLA 2019-10-15 14:59:20 EDT 
New Gerrit change created: https://git.eclipse.org/r/151121