Bug 552005 - Project Explorer EmptyWorkspaceHelper is not extensible and breaks ProjectExplorer extensibility
Summary: Project Explorer EmptyWorkspaceHelper is not extensible and breaks ProjectExp...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.14   Edit
Hardware: PC All
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-10 07:51 EDT by Luca D\'Onofrio CLA
Modified: 2019-12-11 05:34 EST (History)
2 users (show)

See Also:


Attachments
Example project (7.00 KB, application/zip)
2019-10-15 10:14 EDT, Luca D\'Onofrio CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Luca D\'Onofrio CLA 2019-10-10 07:51:55 EDT
With the new Eclipse, I've noticed that the ProjectExplorer implements an EmptyWorkspaceHelper that provides a feedback to the user on "how to start".
That is a really nice feature, however, it breaks the extensibility of the ProjectExplorer.

My project had a DND associated to the ProjectExplorer View to allow users to Drag and Drop projects, thus the IDE will automatically import them:

   <extension
         point="org.eclipse.ui.navigator.navigatorContent">
      <navigatorContent
      		priority="high"
      		providesSaveables="false"
            activeByDefault="true"
            contentProvider="xxx.MyEmptyProvider"
            icon="my_icon.gif"
            id="xxx.projectDNDAssistant"
            labelProvider="xxx.MyEmptyLabelProvider"
            name="Project DND Importer Assistant">
            
         <triggerPoints/>
         <possibleChildren/>
         
         <dropAssistant
               id="xxx.dropAssistant"
               class="xxx.ProjectDNDImporter">
            <possibleDropTargets/>
         </dropAssistant>     
 		 
      </navigatorContent>
   </extension>

With current implementation of the ProjectExplorer, this listener is not called because of the EmptyWorkspaceHelper.

It would be helpful if the Helper inherits ProjectExplorer listener, or alternatively, if the EmptyWorkspaceHelper provides extension points for this (or similar) purpose.

Thanks, regards.
Luca
Comment 1 Karsten Thoms CLA 2019-10-10 08:12:36 EDT
Please attach a sample project for reproduction and describe how you would expect to interact with the extension.
Comment 2 Luca D\'Onofrio CLA 2019-10-15 10:14:27 EDT
Created attachment 280264 [details]
Example project
Comment 3 Lars Vogel CLA 2019-12-10 12:38:13 EST
Luca, could you provide a Gerrit for the fix?
Comment 4 Luca D\'Onofrio CLA 2019-12-11 04:39:23 EST
Hi Lars, I don't actually have any fix, I have just raised the issue.
Comment 5 Lars Vogel CLA 2019-12-11 04:55:41 EST
(In reply to Luca D\'Onofrio from comment #4)
> Hi Lars, I don't actually have any fix, I have just raised the issue.

Please feel encouraged to work on a fix if that functionality is important to you. Not sure if another developer will give this priority. Lots of our developers contribute in their free time. See https://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html#exericse-eclipse-user-creation-and-gerrit-server-configuration for the required setup.
Comment 6 Luca D\'Onofrio CLA 2019-12-11 05:34:47 EST
(In reply to Lars Vogel from comment #5)
> (In reply to Luca D\'Onofrio from comment #4)
> > Hi Lars, I don't actually have any fix, I have just raised the issue.
> 
> Please feel encouraged to work on a fix if that functionality is important
> to you. Not sure if another developer will give this priority. Lots of our
> developers contribute in their free time. See
> https://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.
> html#exericse-eclipse-user-creation-and-gerrit-server-configuration for the
> required setup.

Ok thanks for letting me know :)
I'll keep you posted.

Regards